Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 319953002: Task Manager: Remove dead FPS code. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
palmer, Yoyo Zhou, jam, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jbauman, nduca
Visibility:
Public.

Description

Task Manager: Remove dead FPS code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275670

Patch Set 1 #

Patch Set 2 : remove from processes.json as well #

Patch Set 3 : and from the example as well #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -171 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_api_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/task_manager/renderer_resource.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/task_manager/renderer_resource.cc View 5 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/task_manager/resource_provider.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/resource_provider.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 4 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 6 chunks +0 lines, -42 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/processes.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/processes/process_monitor/popup.js View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Lei Zhang
The FPS column in the task manager has been reporting 0 for a while. Unless ...
6 years, 6 months ago (2014-06-06 19:00:02 UTC) #1
Lei Zhang
+nduca FYI
6 years, 6 months ago (2014-06-06 19:01:46 UTC) #2
palmer
IPC security LGTM.
6 years, 6 months ago (2014-06-06 19:16:59 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-06 19:55:44 UTC) #4
jam
lgtm
6 years, 6 months ago (2014-06-06 20:13:06 UTC) #5
Yoyo Zhou
You should also remove it from the API in processes.json. The fps parameter doesn't appear ...
6 years, 6 months ago (2014-06-06 20:45:26 UTC) #6
Lei Zhang
On 2014/06/06 20:45:26, Yoyo Zhou wrote: > You should also remove it from the API ...
6 years, 6 months ago (2014-06-06 20:51:14 UTC) #7
Yoyo Zhou
LGTM
6 years, 6 months ago (2014-06-06 21:32:55 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-06 21:39:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/319953002/40001
6 years, 6 months ago (2014-06-06 21:41:02 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 04:42:24 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 04:46:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/11767) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/193133) chromium_presubmit ...
6 years, 6 months ago (2014-06-07 04:46:10 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-07 05:30:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/319953002/60001
6 years, 6 months ago (2014-06-07 05:30:38 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 09:28:22 UTC) #16
Message was sent while issue was closed.
Change committed as 275670

Powered by Google App Engine
This is Rietveld 408576698