Enable Oilpan for modules/geolocation by default.

Enable Oilpan for modules/geolocation by default.

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175769

[tkent, 2014-06-06 01:05:22]

Please review this.

Changes in bindings/ and modules/geolocation/ are trivial.
We need some changes to public/web/ and Source/web/ because blink_gc_plugin
warns raw pointers to GC objects.

[haraken, 2014-06-06 01:31:55]

https://codereview.chromium.org/319863003/diff/1/Source/web/WebGeolocationPer...
File Source/web/WebGeolocationPermissionRequestManager.cpp (right):

https://codereview.chromium.org/319863003/diff/1/Source/web/WebGeolocationPer...
Source/web/WebGeolocationPermissionRequestManager.cpp:38: typedef
PersistentHeapHashMap<int, Member<Geolocation> > IdGeolocationMap;

Won't these Members cause a cycle?

Even if you explicitly remove Members from the hash maps, you need to use
WeakMembers to prevent them from causing a cycle.

[tkent, 2014-06-06 02:29:06]

https://codereview.chromium.org/319863003/diff/1/Source/web/WebGeolocationPer...
File Source/web/WebGeolocationPermissionRequestManager.cpp (right):

https://codereview.chromium.org/319863003/diff/1/Source/web/WebGeolocationPer...
Source/web/WebGeolocationPermissionRequestManager.cpp:38: typedef
PersistentHeapHashMap<int, Member<Geolocation> > IdGeolocationMap;
On 2014/06/06 01:31:54, haraken wrote:
> 
> Won't these Members cause a cycle?
> 
> Even if you explicitly remove Members from the hash maps, you need to use
> WeakMembers to prevent them from causing a cycle.

I don't think this causes any cycles. I don't understand why you afraid it with
this code.

[haraken, 2014-06-06 02:34:34]

LGTM

https://codereview.chromium.org/319863003/diff/1/Source/web/WebGeolocationPer...
File Source/web/WebGeolocationPermissionRequestManager.cpp (right):

https://codereview.chromium.org/319863003/diff/1/Source/web/WebGeolocationPer...
Source/web/WebGeolocationPermissionRequestManager.cpp:38: typedef
PersistentHeapHashMap<int, Member<Geolocation> > IdGeolocationMap;
On 2014/06/06 02:29:06, tkent wrote:
> On 2014/06/06 01:31:54, haraken wrote:
> > 
> > Won't these Members cause a cycle?
> > 
> > Even if you explicitly remove Members from the hash maps, you need to use
> > WeakMembers to prevent them from causing a cycle.
> 
> I don't think this causes any cycles. I don't understand why you afraid it
with
> this code.
> 

oh, sorry, I was misreading the code. Ignore my comment.

[Michael van Ouwerkerk, 2014-06-06 10:16:07]

LGTM thanks!

[tkent, 2014-06-09 03:07:29]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-09 03:07:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/319863003/1

[commit-bot: I haz the power, 2014-06-09 03:18:16]

Change committed as 175769