Enable Oilpan for modules/geolocation by default.

Source/web/WebGeolocationPermissionRequestManager.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
  *     documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "public/web/WebGeolocationPermissionRequestManager.h"
 
+#include "modules/geolocation/Geolocation.h"
 #include "public/web/WebGeolocationPermissionRequest.h"
 #include "wtf/HashMap.h"
 
 namespace blink {
 
 using namespace WebCore;
 
-typedef HashMap<Geolocation*, int> GeolocationIdMap;
-typedef HashMap<int, Geolocation*> IdGeolocationMap;
+typedef PersistentHeapHashMap<Member<Geolocation>, int> GeolocationIdMap;
+typedef PersistentHeapHashMap<int, Member<Geolocation> > IdGeolocationMap;

[haraken, 2014/06/06 01:31:54]

Won't these Members cause a cycle?

Even if you explicitly remove Members from the hash maps, you need to use
WeakMembers to prevent them from causing a cycle.

[tkent, 2014/06/06 02:29:06]

I don't think this causes any cycles. I don't understand why you afraid it with
this code.

[haraken, 2014/06/06 02:34:34]

oh, sorry, I was misreading the code. Ignore my comment.

 
 class WebGeolocationPermissionRequestManagerPrivate {
 public:
     GeolocationIdMap m_geolocationIdMap;
     IdGeolocationMap m_idGeolocationMap;
 };
 
 int WebGeolocationPermissionRequestManager::add(const blink::WebGeolocationPermissionRequest& permissionRequest)
 {
     Geolocation* geolocation = permissionRequest.geolocation();
@@ skipping 33 matching lines @@
 {
     m_private.reset(new WebGeolocationPermissionRequestManagerPrivate);
 }
 
 void WebGeolocationPermissionRequestManager::reset()
 {
     m_private.reset(0);
 }
 
 } // namespace blink