Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2222)

Unified Diff: Source/web/WebGeolocationPermissionRequestManager.cpp

Issue 319863003: Enable Oilpan for modules/geolocation by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebGeolocationPermissionRequest.cpp ('k') | Source/web/WebGeolocationPosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebGeolocationPermissionRequestManager.cpp
diff --git a/Source/web/WebGeolocationPermissionRequestManager.cpp b/Source/web/WebGeolocationPermissionRequestManager.cpp
index e4dae0830eb6a5afb05d77405cd8cc351fea650c..fb45a1ec30bd4c6b669715a5e8577007aa9ebd0c 100644
--- a/Source/web/WebGeolocationPermissionRequestManager.cpp
+++ b/Source/web/WebGeolocationPermissionRequestManager.cpp
@@ -26,6 +26,7 @@
#include "config.h"
#include "public/web/WebGeolocationPermissionRequestManager.h"
+#include "modules/geolocation/Geolocation.h"
#include "public/web/WebGeolocationPermissionRequest.h"
#include "wtf/HashMap.h"
@@ -33,8 +34,8 @@ namespace blink {
using namespace WebCore;
-typedef HashMap<Geolocation*, int> GeolocationIdMap;
-typedef HashMap<int, Geolocation*> IdGeolocationMap;
+typedef PersistentHeapHashMap<Member<Geolocation>, int> GeolocationIdMap;
+typedef PersistentHeapHashMap<int, Member<Geolocation> > IdGeolocationMap;
haraken 2014/06/06 01:31:54 Won't these Members cause a cycle? Even if you ex
tkent 2014/06/06 02:29:06 I don't think this causes any cycles. I don't unde
haraken 2014/06/06 02:34:34 oh, sorry, I was misreading the code. Ignore my co
class WebGeolocationPermissionRequestManagerPrivate {
public:
« no previous file with comments | « Source/web/WebGeolocationPermissionRequest.cpp ('k') | Source/web/WebGeolocationPosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698