Chromium Code Reviews| Index: Source/web/WebGeolocationPermissionRequestManager.cpp |
| diff --git a/Source/web/WebGeolocationPermissionRequestManager.cpp b/Source/web/WebGeolocationPermissionRequestManager.cpp |
| index e4dae0830eb6a5afb05d77405cd8cc351fea650c..fb45a1ec30bd4c6b669715a5e8577007aa9ebd0c 100644 |
| --- a/Source/web/WebGeolocationPermissionRequestManager.cpp |
| +++ b/Source/web/WebGeolocationPermissionRequestManager.cpp |
| @@ -26,6 +26,7 @@ |
| #include "config.h" |
| #include "public/web/WebGeolocationPermissionRequestManager.h" |
| +#include "modules/geolocation/Geolocation.h" |
| #include "public/web/WebGeolocationPermissionRequest.h" |
| #include "wtf/HashMap.h" |
| @@ -33,8 +34,8 @@ namespace blink { |
| using namespace WebCore; |
| -typedef HashMap<Geolocation*, int> GeolocationIdMap; |
| -typedef HashMap<int, Geolocation*> IdGeolocationMap; |
| +typedef PersistentHeapHashMap<Member<Geolocation>, int> GeolocationIdMap; |
| +typedef PersistentHeapHashMap<int, Member<Geolocation> > IdGeolocationMap; |
|
haraken
2014/06/06 01:31:54
Won't these Members cause a cycle?
Even if you ex
tkent
2014/06/06 02:29:06
I don't think this causes any cycles. I don't unde
haraken
2014/06/06 02:34:34
oh, sorry, I was misreading the code. Ignore my co
|
| class WebGeolocationPermissionRequestManagerPrivate { |
| public: |