Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection

Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection (Closed)

Created:
6 years, 6 months ago by apavlov

Modified:
6 years, 6 months ago

Reviewers:
aandrey, sergeyv

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection R=aandrey, sergeyv NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175648

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix constructor detection for unnamed functions #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -73 lines)			Patch
M	Source/devtools/scripts/jsdoc-validator/hashes	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/jsdoc-validator.jar	View	1	Binary file		0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java	View		2 chunks	+32 lines, -28 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionReceiverChecker.java	View		2 chunks	+11 lines, -5 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/MethodAnnotationChecker.java	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ProtoFollowsExtendsChecker.java	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/tests/function.js	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	Source/devtools/scripts/jsdoc-validator/tests/golden.dat	View	1	2 chunks	+29 lines, -25 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sergeyv

Overall it looks good, just one nit comment https://codereview.chromium.org/319733002/diff/10001/Source/devtools/front_end/sdk/InspectorBackend.js File Source/devtools/front_end/sdk/InspectorBackend.js (right): https://codereview.chromium.org/319733002/diff/10001/Source/devtools/front_end/sdk/InspectorBackend.js#newcode53 Source/devtools/front_end/sdk/InspectorBackend.js:53: * ...

6 years, 6 months ago (2014-06-05 17:13:37 UTC) #2

apavlov

https://codereview.chromium.org/319733002/diff/10001/Source/devtools/front_end/sdk/InspectorBackend.js File Source/devtools/front_end/sdk/InspectorBackend.js (right): https://codereview.chromium.org/319733002/diff/10001/Source/devtools/front_end/sdk/InspectorBackend.js#newcode53 Source/devtools/front_end/sdk/InspectorBackend.js:53: * @this {InspectorBackendClass} On 2014/06/05 17:13:36, sergeyv wrote: > ...

6 years, 6 months ago (2014-06-05 18:41:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/319733002/30001

6 years, 6 months ago (2014-06-06 09:18:58 UTC) #6

Message was sent while issue was closed.

Change committed as 175648

Expand Messages | Collapse Messages