Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix constructor detection for unnamed functions Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/tests/function.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:1: ERROR - @return annotation is requi red for API functions that return value 1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:1: ERROR - @return annotation is requi red for API functions that return value
2 function badFuncNoAnnotation() { 2 function badFuncNoAnnotation() {
3 ^ 3 ^
4 4
5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:8: ERROR - @return annotation found, y et function does not return value 5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:8: ERROR - @return annotation found, y et function does not return value
6 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation. 6 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation.
7 ^ 7 ^
8 8
9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:15: ERROR - @return annotation found, yet function does not return value 9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:15: ERROR - @return annotation found, yet function does not return value
10 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value. 10 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value.
(...skipping 24 matching lines...) Expand all
35 ^ 35 ^
36 36
37 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:63: ERROR - invalid return type annota tion found - please remove, as function does not return value 37 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:63: ERROR - invalid return type annota tion found - please remove, as function does not return value
38 * @returns {number} 38 * @returns {number}
39 ^ 39 ^
40 40
41 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:80: ERROR - @return annotation is requ ired for API functions that return value 41 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:80: ERROR - @return annotation is requ ired for API functions that return value
42 badApiMethodNoAnnotation: function() // ERROR - public method. 42 badApiMethodNoAnnotation: function() // ERROR - public method.
43 ^ 43 ^
44 44
45 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:109: ERROR - @return annotation found, yet function does not return value 45 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:97: ERROR - @this annotation is requir ed for functions referencing 'this'
46 /**
47 ^
48
49 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:126: ERROR - @return annotation found, yet function does not return value
46 badMethodDoesNotReturnValue: function() // ERROR - does not return value. 50 badMethodDoesNotReturnValue: function() // ERROR - does not return value.
47 ^ 51 ^
48 52
49 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:117: ERROR - @return annotation found, yet function does not return value 53 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:134: ERROR - @return annotation found, yet function does not return value
50 badMethodDoesNotReturn: function() // ERROR - does not return. 54 badMethodDoesNotReturn: function() // ERROR - does not return.
51 ^ 55 ^
52 56
53 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:123: ERROR - invalid return type annot ation found - should be "@return {<type>}" 57 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:140: ERROR - invalid return type annot ation found - should be "@return {<type>}"
54 * @returns {number} 58 * @returns {number}
55 ^ 59 ^
56 60
57 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:131: ERROR - invalid return type annot ation found - please remove, as function does not return value 61 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:148: ERROR - invalid return type annot ation found - please remove, as function does not return value
58 * @returns {number} 62 * @returns {number}
59 ^ 63 ^
60 64
61 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:139: ERROR - invalid return type annot ation found - please remove, as function does not return value 65 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:156: ERROR - invalid return type annot ation found - please remove, as function does not return value
62 * @returns {number} 66 * @returns {number}
63 ^ 67 ^
64 68
65 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:159: ERROR - @return annotation is req uired for API functions that return value 69 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:176: ERROR - @return annotation is req uired for API functions that return value
66 badApiMethodNoAnnotation: function() // ERROR - public method. 70 badApiMethodNoAnnotation: function() // ERROR - public method.
67 ^ 71 ^
68 72
69 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:180: ERROR - @return annotation found, yet function does not return value 73 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:197: ERROR - @return annotation found, yet function does not return value
70 badMethodDoesNotReturnValue: function() // ERROR - does not return value. 74 badMethodDoesNotReturnValue: function() // ERROR - does not return value.
71 ^ 75 ^
72 76
73 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:188: ERROR - @return annotation found, yet function does not return value 77 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:205: ERROR - @return annotation found, yet function does not return value
74 badMethodDoesNotReturn: function() // ERROR - does not return. 78 badMethodDoesNotReturn: function() // ERROR - does not return.
75 ^ 79 ^
76 80
77 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:194: ERROR - invalid return type annot ation found - should be "@return {<type>}" 81 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:211: ERROR - invalid return type annot ation found - should be "@return {<type>}"
78 * @returns {number} 82 * @returns {number}
79 ^ 83 ^
80 84
81 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:202: ERROR - invalid return type annot ation found - please remove, as function does not return value 85 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:219: ERROR - invalid return type annot ation found - please remove, as function does not return value
82 * @returns {number} 86 * @returns {number}
83 ^ 87 ^
84 88
85 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:210: ERROR - invalid return type annot ation found - please remove, as function does not return value 89 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:227: ERROR - invalid return type annot ation found - please remove, as function does not return value
86 * @returns {number} 90 * @returns {number}
87 ^ 91 ^
88 92
89 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:230: ERROR - invalid return type annot ation found - should be "@return {<type>}" 93 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:247: ERROR - invalid return type annot ation found - should be "@return {<type>}"
90 * @returns {number} 94 * @returns {number}
91 ^ 95 ^
92 96
93 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:251: ERROR - @return annotation is req uired for API functions that return value 97 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:268: ERROR - @return annotation is req uired for API functions that return value
94 badApiMethodNoAnnotation: function() // ERROR - public method. 98 badApiMethodNoAnnotation: function() // ERROR - public method.
95 ^ 99 ^
96 100
97 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:272: ERROR - @return annotation found, yet function does not return value 101 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:289: ERROR - @return annotation found, yet function does not return value
98 badMethodDoesNotReturnValue: function() // ERROR - does not return value. 102 badMethodDoesNotReturnValue: function() // ERROR - does not return value.
99 ^ 103 ^
100 104
101 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:280: ERROR - @return annotation found, yet function does not return value 105 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:297: ERROR - @return annotation found, yet function does not return value
102 badMethodDoesNotReturn: function() // ERROR - does not return. 106 badMethodDoesNotReturn: function() // ERROR - does not return.
103 ^ 107 ^
104 108
105 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:286: ERROR - invalid return type annot ation found - should be "@return {<type>}" 109 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:303: ERROR - invalid return type annot ation found - should be "@return {<type>}"
106 * @returns {number} 110 * @returns {number}
107 ^ 111 ^
108 112
109 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:294: ERROR - invalid return type annot ation found - should be "@return {<type>}" 113 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:311: ERROR - invalid return type annot ation found - should be "@return {<type>}"
110 * @returns number 114 * @returns number
111 ^ 115 ^
112 116
113 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:302: ERROR - invalid return type annot ation found - please remove, as function does not return value 117 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:319: ERROR - invalid return type annot ation found - please remove, as function does not return value
114 * @returns {number} 118 * @returns {number}
115 ^ 119 ^
116 120
117 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:310: ERROR - invalid return type annot ation found - please remove, as function does not return value 121 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:327: ERROR - invalid return type annot ation found - please remove, as function does not return value
118 * @returns {number} 122 * @returns {number}
119 ^ 123 ^
120 124
121 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:318: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName" 125 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:335: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName"
122 * @param number foo 126 * @param number foo
123 ^ 127 ^
124 128
125 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:319: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName" 129 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:336: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName"
126 * @param bar 130 * @param bar
127 ^ 131 ^
128 132
129 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:321: ERROR - @return annotation is req uired for API functions that return value 133 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:338: ERROR - @return annotation is req uired for API functions that return value
130 badMethodParamAnnotations: function(foo, bar) // ERROR - @param's should be well-formed 134 badMethodParamAnnotations: function(foo, bar) // ERROR - @param's should be well-formed
131 ^ 135 ^
132 136
133 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:340: ERROR - No @param JSDoc tag found for parameters: [b] 137 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:357: ERROR - No @param JSDoc tag found for parameters: [b]
134 /** 138 /**
135 ^ 139 ^
136 140
137 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:346: ERROR - No @param JSDoc tag found for parameters: [b,c] 141 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:363: ERROR - No @param JSDoc tag found for parameters: [b,c]
138 /** 142 /**
139 ^ 143 ^
140 144
141 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends 145 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends
142 * @extends {Base} 146 * @extends {Base}
143 ^ 147 ^
144 148
145 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor 149 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor
146 DerivedNoProto = function() {} 150 DerivedNoProto = function() {}
147 ^ 151 ^
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 ^ 323 ^
320 324
321 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:268: ERROR - @this annotation is required for functions referencing 'this' 325 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:268: ERROR - @this annotation is required for functions referencing 'this'
322 function callbackReferencingThisNotAnnotated() 326 function callbackReferencingThisNotAnnotated()
323 ^ 327 ^
324 328
325 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:277: ERROR - @this annotation found for fu nction not referencing 'this' 329 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:277: ERROR - @this annotation found for fu nction not referencing 'this'
326 function callbackNotReferencingThisAnnotated() 330 function callbackNotReferencingThisAnnotated()
327 ^ 331 ^
328 332
329 Total errors: 82 333 Total errors: 83
OLDNEW
« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/tests/function.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698