Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java - Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java

Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix constructor detection for unnamed functions Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionReceiverChecker.java ('k') | Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/MethodAnnotationChecker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java

index 3fa600d60b8f7bed95585a1e665087ef78930499..47621e10b7129112a2e00f3859b0d8998466ec89 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java

@@ -1,18 +1,22 @@

package org.chromium.devtools.jsdoc.checks;

+import com.google.javascript.rhino.head.ast.Comment;

import com.google.javascript.rhino.head.ast.FunctionNode;

public class FunctionRecord {

final FunctionNode functionNode;

+ final Comment jsDocNode;

final String name;

final boolean isConstructor;

final String returnType;

final TypeRecord enclosingType;

final FunctionRecord enclosingFunctionRecord;

- public FunctionRecord(FunctionNode functionNode, String name, boolean isConstructor,

- String returnType, TypeRecord parentType, FunctionRecord enclosingFunctionRecord) {

+ public FunctionRecord(FunctionNode functionNode, Comment jsDocNode, String name,

+ boolean isConstructor, String returnType, TypeRecord parentType,

+ FunctionRecord enclosingFunctionRecord) {

this.functionNode = functionNode;

+ this.jsDocNode = jsDocNode;

this.name = name;

this.isConstructor = isConstructor;

this.returnType = returnType;