Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc
diff --git a/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc b/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc
index 8a1c02309c9c70dea4010ab6a9be42161b700a10..68b8579a7afcb1c4957b5f6205e4b0807458ddfe 100644
--- a/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc
+++ b/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc
@@ -48,3 +48,18 @@ void BrowserContentSettingBubbleModelDelegate::ShowContentSettingsPage(
return;
}
}
+
+void BrowserContentSettingBubbleModelDelegate::ShowLearnMorePage(
+ ContentSettingsType type) {
+ switch (type) {
felt 2014/06/11 02:37:30 Does this make sense as a switch, if there's only
radhikabhar 2014/06/11 17:31:46 Done.
+ case CONTENT_SETTINGS_TYPE_PLUGINS:
+ chrome::AddSelectedTabWithURL(
+ browser_,
+ google_util::AppendGoogleLocaleParam(
+ GURL(chrome::kBlockedPluginLearnMoreURL)),
+ content::PAGE_TRANSITION_LINK);
+ return;
+ default:
+ return;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698