Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h" 5 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
6 6
7 #include "chrome/browser/google/google_util.h" 7 #include "chrome/browser/google/google_util.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_dialogs.h" 9 #include "chrome/browser/ui/browser_dialogs.h"
10 #include "chrome/browser/ui/browser_tabstrip.h" 10 #include "chrome/browser/ui/browser_tabstrip.h"
(...skipping 30 matching lines...) Expand all
41 content::PAGE_TRANSITION_LINK); 41 content::PAGE_TRANSITION_LINK);
42 return; 42 return;
43 case CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS: 43 case CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS:
44 chrome::ShowSettingsSubPage(browser_, chrome::kHandlerSettingsSubPage); 44 chrome::ShowSettingsSubPage(browser_, chrome::kHandlerSettingsSubPage);
45 return; 45 return;
46 default: 46 default:
47 chrome::ShowContentSettings(browser_, type); 47 chrome::ShowContentSettings(browser_, type);
48 return; 48 return;
49 } 49 }
50 } 50 }
51
52 void BrowserContentSettingBubbleModelDelegate::ShowLearnMorePage(
53 ContentSettingsType type) {
54 switch (type) {
felt 2014/06/11 02:37:30 Does this make sense as a switch, if there's only
radhikabhar 2014/06/11 17:31:46 Done.
55 case CONTENT_SETTINGS_TYPE_PLUGINS:
56 chrome::AddSelectedTabWithURL(
57 browser_,
58 google_util::AppendGoogleLocaleParam(
59 GURL(chrome::kBlockedPluginLearnMoreURL)),
60 content::PAGE_TRANSITION_LINK);
61 return;
62 default:
63 return;
64 }
65 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698