Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing

chrome/browser/content_settings/tab_specific_content_settings.h

Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index 063faa95fe36c2409d6d0d5dd24e9084cb363de0..eeb9f64b01dcb4e706b8acc23180770367a21633 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -258,6 +258,15 @@ class TabSpecificContentSettings
     return pending_protocol_handler_setting_;
   }
 
+  //Set whether the setting for the plugin bubble mode is Allow, Block or Run

[felt, 2014/06/11 02:37:29]

You need a space and a period at the end of the sentence, like: 

// Set whether ...
// this time.

[radhikabhar, 2014/06/11 17:31:46]

Done.

+  //this time
+  void set_plugin_bubble_setting(ContentSetting setting) {
+    plugin_bubble_setting_ = setting;
+  }
+
+  ContentSetting plugin_bubble_setting() const {
+    return plugin_bubble_setting_;
+  }
 
   // Returns a pointer to the |LocalSharedObjectsContainer| that contains all
   // allowed local shared objects like cookies, local storage, ... .
@@ -271,6 +280,8 @@ class TabSpecificContentSettings
     return blocked_local_shared_objects_;
   }
 
+  // TODO(radhikabhar): This is no longer needed as we have deleted the custom

[felt, 2014/06/11 02:37:29]

Why is this a TODO? Why aren't you doing it right here?

[radhikabhar, 2014/06/11 17:31:46]

Removed it

+  // link in the plugin bubble model
   bool load_plugins_link_enabled() { return load_plugins_link_enabled_; }
   void set_load_plugins_link_enabled(bool enabled) {
     load_plugins_link_enabled_ = enabled;
@@ -405,6 +416,12 @@ class TabSpecificContentSettings
   // the user opens the bubble and makes changes multiple times.
   ContentSetting pending_protocol_handler_setting_;
 
+  // The setting on the plugin bubble model. Persisted in case
+  // the user opens the bubble and makes changes multiple times.
+  ContentSetting plugin_bubble_setting_;
+
+  // TODO(radhikabhar): This is no longer needed as we have got rid of the
+  // custom link

[felt, 2014/06/11 02:37:29]

Same question, why is this a TODO?

[radhikabhar, 2014/06/11 17:31:46]

Done.

   // Stores whether the user can load blocked plugins on this page.
   bool load_plugins_link_enabled_;