Fix window leaks related to the suggestion popup.

Fix window leaks related to the suggestion popup.

Currently, Chrome Shell leaks the suggestion popup window when terminating.
We need to handle it as the clank does.

android.view.WindowLeaked: Activity org.chromium.chrome.shell.ChromeShellActivity has leaked window android.widget.PopupWindow$PopupViewContainer that was originally added here
    at android.view.ViewRootImpl.<init>(ViewRootImpl.java:348)
    at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
    at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
    at android.widget.PopupWindow.invokePopup(PopupWindow.java:1019)
    at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:925)
    at android.widget.ListPopupWindow.show(ListPopupWindow.java:625)
    at org.chromium.chrome.shell.omnibox.SuggestionPopup.onSuggestionsReceived(SuggestionPopup.java:126)
    at org.chromium.chrome.browser.omnibox.AutocompleteController.onSuggestionsReceived(AutocompleteController.java:175)
    at org.chromium.chrome.browser.omnibox.AutocompleteController.nativeStart(Native Method)
    at org.chromium.chrome.browser.omnibox.AutocompleteController.start(AutocompleteController.java:79)
    at org.chromium.chrome.shell.omnibox.SuggestionPopup$4.run(SuggestionPopup.java:148)
    at android.os.Handler.handleCallback(Handler.java:733)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:136)
    at android.app.ActivityThread.main(ActivityThread.java:5017)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:515)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
    at dalvik.system.NativeStart.main(Native Method)

BUG=380224
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275379

[Sungmann Cho, 2014-06-05 12:14:49]

Please take a look. Thanks!

[aurimas (slooooooooow), 2014-06-05 16:24:09]

lgtm after nits

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:81:
public void hideSuggestions() {
Please add a javadoc comment.

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
(right):

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:82:
public void hideSuggestions() {
Please add a javadoc comment.

[Ted C, 2014-06-05 18:44:19]

owners lgtm w/ aurimas's comments addressed

[Sungmann Cho, 2014-06-05 23:00:11]

aurimas@ Could you please take a look at the javadoc comments and let me know if
it's not reasonable. Thanks!

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:81:
public void hideSuggestions() {
On 2014/06/05 16:24:10, aurimas wrote:
> Please add a javadoc comment.

Done.

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
(right):

https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:82:
public void hideSuggestions() {
On 2014/06/05 16:24:10, aurimas wrote:
> Please add a javadoc comment.

Done.

[aurimas (slooooooooow), 2014-06-05 23:03:44]

On 2014/06/05 23:00:11, Sungmann Cho wrote:
> aurimas@ Could you please take a look at the javadoc comments and let me know
if
> it's not reasonable. Thanks!
> 
>
https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
> (right):
> 
>
https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:81:
> public void hideSuggestions() {
> On 2014/06/05 16:24:10, aurimas wrote:
> > Please add a javadoc comment.
> 
> Done.
> 
>
https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
> (right):
> 
>
https://codereview.chromium.org/319553006/diff/1/chrome/android/shell/java/sr...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:82:
> public void hideSuggestions() {
> On 2014/06/05 16:24:10, aurimas wrote:
> > Please add a javadoc comment.
> 
> Done.

Seems reasonable.

[Sungmann Cho, 2014-06-05 23:14:16]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-06-05 23:15:36]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/319553006/2...

[commit-bot: I haz the power, 2014-06-06 10:35:22]

Change committed as 275379