chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java - Issue 319553006: Fix window leaks related to the suggestion popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

Issue 319553006: Fix window leaks related to the suggestion popup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add javadoc comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

index 16f1dae60842283dd73af9e8cb29a0b9c1ef79ab..5d9999a43d24b0ba833dc7e078ec63600a04573a 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

@@ -78,6 +78,13 @@ public class ChromeShellToolbar extends LinearLayout {

if (progress == 100) postDelayed(mClearProgressRunnable, COMPLETED_PROGRESS_TIMEOUT_MS);

}

+ /**

+ * Closes the suggestion popup.

+ */

+ public void hideSuggestions() {

+ if (mSuggestionPopup != null) mSuggestionPopup.hideSuggestions();

+ }

@Override

protected void onFinishInflate() {

super.onFinishInflate();