Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3329)

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 319553006: Fix window leaks related to the suggestion popup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add javadoc comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
index 9f906669a0cbbcf619c7602696891a75da4fb73d..f7d4a5eb3c6a2699620d39b2b09f12eec6cd8973 100644
--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
@@ -70,6 +70,7 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe
private WindowAndroid mWindow;
private TabManager mTabManager;
+ private ChromeShellToolbar mToolbar;
private DevToolsServer mDevToolsServer;
private SyncController mSyncController;
private PrintingController mPrintingController;
@@ -160,7 +161,7 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe
if (!TextUtils.isEmpty(startupUrl)) {
mTabManager.setStartupUrl(startupUrl);
}
- ChromeShellToolbar mToolbar = (ChromeShellToolbar) findViewById(R.id.toolbar);
+ mToolbar = (ChromeShellToolbar) findViewById(R.id.toolbar);
mAppMenuHandler = sAppMenuHandlerFactory.getAppMenuHandler(this, this, R.menu.main_menu);
mToolbar.setMenuHandler(mAppMenuHandler);
@@ -217,6 +218,8 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe
protected void onStop() {
super.onStop();
+ if (mToolbar != null) mToolbar.hideSuggestions();
+
ContentViewCore viewCore = getActiveContentViewCore();
if (viewCore != null) viewCore.onHide();
}
« no previous file with comments | « no previous file | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698