On Windows, fail if there are missing files specified in the project.

On Windows, fail if there are missing files specified in the project.

BUG=skia:2638
Committed: https://skia.googlesource.com/skia/+/4962140c9e6623b29417a2fb9ad903641fb0159c

[epoger, 2014-06-04 15:25:41]

https://codereview.chromium.org/319503003/diff/1/gyp_skia
File gyp_skia (right):

https://codereview.chromium.org/319503003/diff/1/gyp_skia#newcode129
gyp_skia:129: # Fail if there are files specified in the project but are missing
maybe...

# Fail if any files specified in the project are missing

https://codereview.chromium.org/319503003/diff/1/gyp_skia#newcode131
gyp_skia:131: os.environ['GYP_GENERATOR_FLAGS'] =
'msvs_error_on_missing_sources=1'
Is it possible for the user to have already specified some GYP_GENERATOR_FLAGS? 
Maybe we need to *append* to it instead of replacing it?

[jvanverth1, 2014-06-04 15:29:04]

On 2014/06/04 15:25:41, epoger wrote:
> https://codereview.chromium.org/319503003/diff/1/gyp_skia
> File gyp_skia (right):
> 
> https://codereview.chromium.org/319503003/diff/1/gyp_skia#newcode129
> gyp_skia:129: # Fail if there are files specified in the project but are
missing
> maybe...
> 
> # Fail if any files specified in the project are missing

Yes, that's better.

> https://codereview.chromium.org/319503003/diff/1/gyp_skia#newcode131
> gyp_skia:131: os.environ['GYP_GENERATOR_FLAGS'] =
> 'msvs_error_on_missing_sources=1'
> Is it possible for the user to have already specified some
GYP_GENERATOR_FLAGS? 
> Maybe we need to *append* to it instead of replacing it?

Pah, users and their options...

... okay, I'll fix it. I guess I should also check whether
msvs_error_on_missing_sources is already set in GYP_GENERATOR_FLAGS, in case the
user set it to 0.

[jvanverth1, 2014-06-04 17:07:13]

https://codereview.chromium.org/319503003/diff/1/gyp_skia
File gyp_skia (right):

https://codereview.chromium.org/319503003/diff/1/gyp_skia#newcode129
gyp_skia:129: # Fail if there are files specified in the project but are missing
On 2014/06/04 15:25:42, epoger wrote:
> maybe...
> 
> # Fail if any files specified in the project are missing

Done.

https://codereview.chromium.org/319503003/diff/1/gyp_skia#newcode131
gyp_skia:131: os.environ['GYP_GENERATOR_FLAGS'] =
'msvs_error_on_missing_sources=1'
On 2014/06/04 15:25:42, epoger wrote:
> Is it possible for the user to have already specified some
GYP_GENERATOR_FLAGS? 
> Maybe we need to *append* to it instead of replacing it?

Done.

[epoger, 2014-06-04 17:09:43]

LGTM with one tiny change

https://codereview.chromium.org/319503003/diff/40001/gyp_skia
File gyp_skia (right):

https://codereview.chromium.org/319503003/diff/40001/gyp_skia#newcode131
gyp_skia:131: ENVVAR_GYP_GENERATOR_FLAGS = 'GYP_GENERATOR_FLAGS'
please move this definition to the top near ENVVAR_GYP_GENERATORS

[tfarina, 2014-06-04 17:23:39]

Rietveld is showing D for GrDistanceFieldTextContext.h and has executable bit
100755, instead of 100644.

[jvanverth1, 2014-06-04 20:30:41]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-06-04 20:31:45]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/jvanverth@google.com/319503003/70001

[sheyang, 2014-06-04 20:38:15]

The CQ bit was unchecked by sheyang@chromium.org

[jvanverth1, 2014-06-04 22:47:40]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-06-04 22:48:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/jvanverth@google.com/319503003/90001

[commit-bot: I haz the power, 2014-06-04 22:58:01]

Change committed as 4962140c9e6623b29417a2fb9ad903641fb0159c