Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: gyp_skia

Issue 319503003: On Windows, fail if there are missing files specified in the project. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Trying to fix patch Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp_skia
diff --git a/gyp_skia b/gyp_skia
index 66adf08cb90b465b680533857a6acb71910d665c..e04fde0563156f2eba876ffb7f4ba27abe02cfcf 100755
--- a/gyp_skia
+++ b/gyp_skia
@@ -29,6 +29,7 @@ sys.path.insert(0, os.path.join(gyp_source_dir, 'pylib'))
import gyp
ENVVAR_GYP_GENERATORS = 'GYP_GENERATORS'
+ENVVAR_GYP_GENERATOR_FLAGS = 'GYP_GENERATOR_FLAGS'
def additional_include_files(args=[]):
@@ -126,6 +127,13 @@ if __name__ == '__main__':
# By default, we build 'most' instead of 'all' or 'everything'. See skia.gyp.
args.extend(['-Gdefault_target=most'])
+ # Fail if any files specified in the project are missing
+ if sys.platform.startswith('win'):
+ gyp_generator_flags = os.getenv(ENVVAR_GYP_GENERATOR_FLAGS, '')
+ if not 'msvs_error_on_missing_sources' in gyp_generator_flags:
+ os.environ[ENVVAR_GYP_GENERATOR_FLAGS] = (
+ gyp_generator_flags + ' msvs_error_on_missing_sources=1')
+
print 'Updating projects from gyp files...'
sys.stdout.flush()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698