Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: gyp_skia

Issue 319503003: On Windows, fail if there are missing files specified in the project. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright 2011 The Android Open Source Project 3 # Copyright 2011 The Android Open Source Project
4 # 4 #
5 # Use of this source code is governed by a BSD-style license that can be 5 # Use of this source code is governed by a BSD-style license that can be
6 # found in the LICENSE file. 6 # found in the LICENSE file.
7 7
8 # This script is a wrapper which invokes gyp with the correct --depth argument, 8 # This script is a wrapper which invokes gyp with the correct --depth argument,
9 # and supports the automatic regeneration of build files if all.gyp is 9 # and supports the automatic regeneration of build files if all.gyp is
10 # changed (Linux-only). 10 # changed (Linux-only).
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 119
120 # Tell gyp to write the build files into output_dir. 120 # Tell gyp to write the build files into output_dir.
121 args.extend(['--generator-output', os.path.abspath(get_output_dir())]) 121 args.extend(['--generator-output', os.path.abspath(get_output_dir())])
122 122
123 # Tell ninja to write its output into the same directory. 123 # Tell ninja to write its output into the same directory.
124 args.extend(['-Goutput_dir=.']) 124 args.extend(['-Goutput_dir=.'])
125 125
126 # By default, we build 'most' instead of 'all' or 'everything'. See skia.gyp. 126 # By default, we build 'most' instead of 'all' or 'everything'. See skia.gyp.
127 args.extend(['-Gdefault_target=most']) 127 args.extend(['-Gdefault_target=most'])
128 128
129 # Fail if there are files specified in the project but are missing
epoger 2014/06/04 15:25:42 maybe... # Fail if any files specified in the pro
jvanverth1 2014/06/04 17:07:14 Done.
130 if sys.platform.startswith('win'):
131 os.environ['GYP_GENERATOR_FLAGS'] = 'msvs_error_on_missing_sources=1'
epoger 2014/06/04 15:25:42 Is it possible for the user to have already specif
jvanverth1 2014/06/04 17:07:14 Done.
132
129 print 'Updating projects from gyp files...' 133 print 'Updating projects from gyp files...'
130 sys.stdout.flush() 134 sys.stdout.flush()
131 135
132 if '--dry-run' in args: 136 if '--dry-run' in args:
133 args.remove('--dry-run') 137 args.remove('--dry-run')
134 print gyp_source_dir, ' '.join(args) 138 print gyp_source_dir, ' '.join(args)
135 else: 139 else:
136 # Off we go... 140 # Off we go...
137 sys.exit(gyp.main(args)) 141 sys.exit(gyp.main(args))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698