Clear the suggested value while setting value for <select> element.

Clear the suggested value while setting value for <select> element.

R=isherman@chromium.org, tkent@chromium.org
BUG=380603
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175768

[ziran.sun, 2014-06-04 14:13:41]

Please review. Thanks!

[Ilya Sherman, 2014-06-04 20:48:42]

Can you add test coverage?  Otherwise LG -- thanks.

[tkent, 2014-06-04 23:34:40]

Please add a test.

[ziran.sun, 2014-06-05 16:39:11]

Layout tests have been added for both <textarea> element and <select> element.
Please review. Thanks!

[Ilya Sherman, 2014-06-05 23:49:40]

https://codereview.chromium.org/319443003/diff/20001/LayoutTests/fast/forms/s...
File LayoutTests/fast/forms/suggested-value-after-setvalue.html (right):

https://codereview.chromium.org/319443003/diff/20001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/suggested-value-after-setvalue.html:5: <pre><input
id="test" type="text" value="initial value"><textarea
id="textarea"></textarea><select
id="select"><option>CA</option><option>TX</option></select></pre>
Can you add linebreaks so that this is more readable, or is it important for all
of this text to be on a single line?

https://codereview.chromium.org/319443003/diff/20001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/suggested-value-after-setvalue.html:54:
addText(innerTextValue == 'new value' ? 'PASS' : 'FAIL');
Hmm, seems like the pass/fail condition ought to be more complex now, no?

[ziran.sun, 2014-06-06 10:32:04]

Updated test file as per Ilya's review comments. All review comments have been
addressed. Please review. Thanks!

[Ilya Sherman, 2014-06-06 18:00:42]

LGTM.  Thanks, Ziran.

[tkent, 2014-06-09 01:01:14]

lgtm

https://codereview.chromium.org/319443003/diff/40001/LayoutTests/fast/forms/s...
File LayoutTests/fast/forms/suggested-value-after-setvalue.html (right):

https://codereview.chromium.org/319443003/diff/40001/LayoutTests/fast/forms/s...
LayoutTests/fast/forms/suggested-value-after-setvalue.html:13: textarea.value =
"initial value";
nit: Use single-quotes for consistency.

[commit-bot: I haz the power, 2014-06-09 01:01:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/319443003/40001

[commit-bot: I haz the power, 2014-06-09 02:35:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11198)

[commit-bot: I haz the power, 2014-06-09 03:12:28]

Change committed as 175768