Source/core/html/HTMLSelectElement.cpp - Issue 319443003: Clear the suggested value while setting value for <select> element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 319443003: Clear the suggested value while setting value for <select> element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test file as per Ilya's review comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/suggested-value-after-setvalue.html ('K') | « LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index 812d4a447090b56997276d374bf386d1fd0697dd..597021b5f195bbd9d0b2c824d86178d1699727c2 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -258,6 +258,7 @@ void HTMLSelectElement::setValue(const String &value, bool sendEvents)

}

int previousSelectedIndex = selectedIndex();

+ setSuggestedIndex(-1);

setSelectedIndex(optionIndex);

if (sendEvents && previousSelectedIndex != selectedIndex()) {

« LayoutTests/fast/forms/suggested-value-after-setvalue.html ('K') | « LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt ('k') | no next file » | no next file with comments »