Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: LayoutTests/fast/forms/suggested-value-after-setvalue.html

Issue 319443003: Clear the suggested value while setting value for <select> element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add layout tests for both <textarea> element and <select> element. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <body> 3 <body>
4 <p id="description">This test setting a value clears suggested value.</p> 4 <p id="description">This test setting a value clears suggested value.</p>
5 <pre><input id="test" type="text" value="initial value"></pre> 5 <pre><input id="test" type="text" value="initial value"><textarea id="textarea"> </textarea><select id="select"><option>CA</option><option>TX</option></select></ pre>
Ilya Sherman 2014/06/05 23:49:39 Can you add linebreaks so that this is more readab
6 <script src="../../resources/dump-as-markup.js"></script> 6 <script src="../../resources/dump-as-markup.js"></script>
7 <script> 7 <script>
8 8
9 var input = document.getElementById('test'); 9 var input = document.getElementById('test');
10 var textarea = document.getElementById('textarea');
11 textarea.value = "initial value";
12 var select = document.getElementById('select');
13 select.selectedIndex = -1;
10 var result = document.getElementById('result'); 14 var result = document.getElementById('result');
11 if (!window.internals) 15 if (!window.internals)
12 testFailed('This test requires internals object'); 16 testFailed('This test requires internals object');
13 else { 17 else {
14 input.focus(); 18 input.focus();
15 input.selectionStart = input.selectionEnd = 0; 19 input.selectionStart = input.selectionEnd = 0;
16 20
17 internals.setSuggestedValue(input, 'suggested value'); 21 internals.setSuggestedValue(input, 'suggested value');
22 internals.setSuggestedValue(textarea, 'suggested value');
23 internals.setSuggestedValue(select, 'TX');
18 24
19 Markup.description(document.getElementById('description').textContent) 25 Markup.description(document.getElementById('description').textContent)
20 26
21 function addText(text) { 27 function addText(text) {
22 input.parentNode.appendChild(document.createTextNode(text)); 28 input.parentNode.appendChild(document.createTextNode(text));
23 } 29 }
24 30
25 function log() { 31 function log() {
26 while (input.parentNode.firstChild != input.parentNode.lastChild) 32 while (input.parentNode.firstChild != input.parentNode.lastChild)
27 input.parentNode.removeChild(input.parentNode.lastChild); 33 input.parentNode.removeChild(input.parentNode.lastChild);
28 function addTextResult(value) { addText(value + ': ' + eval(value)); } 34 function addTextResult(value) { addText(value + ': ' + eval(value)); }
29 addTextResult('input.value'); 35 addTextResult('input.value');
30 addTextResult('internals.suggestedValue(input)'); 36 addTextResult('internals.suggestedValue(input)');
31 addTextResult('input.selectionStart'); 37 addTextResult('input.selectionStart');
32 addTextResult('input.selectionEnd'); 38 addTextResult('input.selectionEnd');
39 addTextResult('textarea.value');
40 addTextResult('internals.suggestedValue(textarea)');
41 addTextResult('select.value');
42 addTextResult('internals.suggestedValue(select)');
33 } 43 }
34 44
35 log(); 45 log();
36 Markup.dump(input.parentNode, 'After setting suggestedValue'); 46 Markup.dump(input.parentNode, 'After setting suggestedValue');
37 47
38 input.value = 'new value'; 48 input.value = 'new value';
49 textarea.value = 'new value';
50 select.value = 'CA';
39 51
40 log(); 52 log();
41 var innerTextValue = internals.shadowRoot(input).firstChild.innerText; 53 var innerTextValue = internals.shadowRoot(input).firstChild.innerText;
42 addText(innerTextValue == 'new value' ? 'PASS' : 'FAIL'); 54 addText(innerTextValue == 'new value' ? 'PASS' : 'FAIL');
Ilya Sherman 2014/06/05 23:49:39 Hmm, seems like the pass/fail condition ought to b
43 Markup.dump(input.parentNode, 'After setting value'); 55 Markup.dump(input.parentNode, 'After setting value');
44 } 56 }
45 57
46 </script> 58 </script>
47 </body> 59 </body>
48 </html> 60 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698