Issue 31933002: IDL compiler: [SetterCallWith]

Issue 31933002: IDL compiler: [SetterCallWith] (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)

Modified:
7 years, 2 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: [SetterCallWith] BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160075

Patch Set 2 : Revised #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -21 lines)			Patch
M	Source/bindings/scripts/unstable/v8_attributes.py	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/bindings/scripts/unstable/v8_callback_interface.py	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/bindings/scripts/unstable/v8_utilities.py	View	1	2 chunks	+8 lines, -9 lines	0 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View		2 chunks	+19 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

Main difference is refactoring, so [SetterCallWith] can override [CallWith].

7 years, 2 months ago (2013-10-21 07:29:18 UTC) #1

haraken

LGTM https://codereview.chromium.org/31933002/diff/1/Source/bindings/scripts/unstable/v8_attributes.py File Source/bindings/scripts/unstable/v8_attributes.py (right): https://codereview.chromium.org/31933002/diff/1/Source/bindings/scripts/unstable/v8_attributes.py#newcode171 Source/bindings/scripts/unstable/v8_attributes.py:171: call_with = attribute.extended_attributes.get('CallWith', '') Why do we need ...

7 years, 2 months ago (2013-10-21 07:36:52 UTC) #2

Nils Barth (inactive)

https://codereview.chromium.org/31933002/diff/1/Source/bindings/scripts/unstable/v8_attributes.py File Source/bindings/scripts/unstable/v8_attributes.py (right): https://codereview.chromium.org/31933002/diff/1/Source/bindings/scripts/unstable/v8_attributes.py#newcode171 Source/bindings/scripts/unstable/v8_attributes.py:171: call_with = attribute.extended_attributes.get('CallWith', '') On 2013/10/21 07:36:52, haraken wrote: ...

7 years, 2 months ago (2013-10-21 08:03:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/31933002/60001

7 years, 2 months ago (2013-10-21 08:03:30 UTC) #4

Message was sent while issue was closed.

Change committed as 160075

Expand Messages | Collapse Messages