IDL compiler: [SetterCallWith]

Source/bindings/scripts/unstable/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 150 matching lines @@
 
 def getter_expression(interface, attribute, contents, includes):
     arguments = []
     if 'Reflect' in attribute.extended_attributes:
         getter_base_name = content_attribute_getter_base_name(attribute, includes, arguments)
     else:
         getter_base_name = uncapitalize(cpp_name(attribute))
 
     getter_name = scoped_name(interface, attribute, getter_base_name)
 
-    arguments.extend(v8_utilities.call_with_arguments(attribute, contents))
+    call_with = attribute.extended_attributes.get('CallWith', '')

[haraken, 2013/10/21 07:36:52]

Why do we need ", ''" ? I'm a bit afraid that it's easy to forget to add it in
the future.

[Nils Barth (inactive), 2013/10/21 08:03:05]

Changed.

|get| defaults to returning None;
this makes it default to returning ''.

We either need to default to '' or handle None specially.
It's about the same either way, but a bit simpler if we special-case None
in the function.

+    arguments.extend(v8_utilities.call_with_arguments(call_with, contents))
     if attribute.is_nullable:
         arguments.append('isNull')
     if contents['is_getter_raises_exception']:
         arguments.append('es')
     if attribute.data_type == 'EventHandler':
         arguments.append('isolatedWorldForIsolate(info.GetIsolate())')
     return '%s(%s)' % (getter_name, ', '.join(arguments))
 
 
 CONTENT_ATTRIBUTE_GETTER_NAMES = {
@@ skipping 30 matching lines @@
     else:
         cpp_value = 'cppValue'
     contents.update({
         'cpp_setter': setter_expression(interface, attribute, contents, includes),
         'enum_validation_expression': enum_validation_expression(idl_type),
         'v8_value_to_local_cpp_value': v8_types.v8_value_to_local_cpp_value(idl_type, attribute.extended_attributes, 'jsValue', 'cppValue', includes, 'info.GetIsolate()'),
     })
 
 
 def setter_expression(interface, attribute, contents, includes):
-    arguments = v8_utilities.call_with_arguments(attribute, contents)
+    call_with = attribute.extended_attributes.get('SetterCallWith') or attribute.extended_attributes.get('CallWith', '')
+    arguments = v8_utilities.call_with_arguments(call_with, contents)
     idl_type = attribute.data_type
     if idl_type == 'EventHandler':
         # FIXME: move V8EventListenerList.h to INCLUDES_FOR_TYPE
         includes.add('bindings/v8/V8EventListenerList.h')
         # FIXME: pass the isolate instead of the isolated world
         isolated_world = 'isolatedWorldForIsolate(info.GetIsolate())'
         arguments.extend(['V8EventListenerList::getEventListener(jsValue, true, ListenerFindOrCreate)', isolated_world])
         contents['event_handler_getter_expression'] = 'imp->%s(%s)' % (cpp_name(attribute), isolated_world)
     elif v8_types.is_interface_type(idl_type) and not v8_types.array_type(idl_type):
         # FIXME: should be able to eliminate WTF::getPtr in most or all cases
@@ skipping 84 matching lines @@
     if 'PerWorldBindings' not in attribute.extended_attributes:
         return '0'
     return '%sV8Internal::%sAttributeGetterCallbackForMainWorld' % (cpp_name(interface), attribute.name)
 
 
 def setter_callback_name_for_main_world(interface, attribute):
     if ('PerWorldBindings' not in attribute.extended_attributes or
         attribute.is_read_only):
         return '0'
     return '%sV8Internal::%sAttributeSetterCallbackForMainWorld' % (cpp_name(interface), attribute.name)