Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: Source/bindings/scripts/unstable/v8_attributes.py

Issue 31933002: IDL compiler: [SetterCallWith] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_callback_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/unstable/v8_attributes.py
diff --git a/Source/bindings/scripts/unstable/v8_attributes.py b/Source/bindings/scripts/unstable/v8_attributes.py
index 135af53db1c4804ef3ac81c966d3349ec0041e7b..6d6b8889c79df58203181c66dc542de705a92e0a 100644
--- a/Source/bindings/scripts/unstable/v8_attributes.py
+++ b/Source/bindings/scripts/unstable/v8_attributes.py
@@ -168,7 +168,8 @@ def getter_expression(interface, attribute, contents, includes):
getter_name = scoped_name(interface, attribute, getter_base_name)
- arguments.extend(v8_utilities.call_with_arguments(attribute, contents))
+ call_with = attribute.extended_attributes.get('CallWith')
+ arguments.extend(v8_utilities.call_with_arguments(call_with, contents))
if attribute.is_nullable:
arguments.append('isNull')
if contents['is_getter_raises_exception']:
@@ -219,7 +220,8 @@ def generate_setter(interface, attribute, contents, includes):
def setter_expression(interface, attribute, contents, includes):
- arguments = v8_utilities.call_with_arguments(attribute, contents)
+ call_with = attribute.extended_attributes.get('SetterCallWith') or attribute.extended_attributes.get('CallWith')
+ arguments = v8_utilities.call_with_arguments(call_with, contents)
idl_type = attribute.data_type
if idl_type == 'EventHandler':
# FIXME: move V8EventListenerList.h to INCLUDES_FOR_TYPE
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_callback_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698