Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319303003: Polish the new SSL interstitial (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
palmer, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, edwardjung
Visibility:
Public.

Description

Polish the new SSL interstitial A few tweaks, per designer's request. BUG=331453 for one-line change to c/b/ssl/ssl_blocking_page.cc: TBR=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276048

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes for review #

Total comments: 3

Patch Set 3 : Set relative sizing #

Patch Set 4 : No png #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M chrome/browser/resources/ssl/interstitial_v2.css View 1 2 4 chunks +32 lines, -13 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
felt
Hi Dan, Can you please review this CL? Polishes up the ssl warning for a ...
6 years, 6 months ago (2014-06-07 01:28:36 UTC) #1
Dan Beam
https://codereview.chromium.org/319303003/diff/1/chrome/browser/resources/ssl/interstitial_v2.css File chrome/browser/resources/ssl/interstitial_v2.css (right): https://codereview.chromium.org/319303003/diff/1/chrome/browser/resources/ssl/interstitial_v2.css#newcode38 chrome/browser/resources/ssl/interstitial_v2.css:38: color: rgb(105, 105, 105); nit: use hex for rr ...
6 years, 6 months ago (2014-06-07 02:04:42 UTC) #2
felt
https://codereview.chromium.org/319303003/diff/1/chrome/browser/resources/ssl/interstitial_v2.css File chrome/browser/resources/ssl/interstitial_v2.css (right): https://codereview.chromium.org/319303003/diff/1/chrome/browser/resources/ssl/interstitial_v2.css#newcode38 chrome/browser/resources/ssl/interstitial_v2.css:38: color: rgb(105, 105, 105); On 2014/06/07 02:04:42, Dan Beam ...
6 years, 6 months ago (2014-06-07 02:56:12 UTC) #3
Dan Beam
https://codereview.chromium.org/319303003/diff/20001/chrome/browser/resources/ssl/interstitial_v2.html File chrome/browser/resources/ssl/interstitial_v2.html (right): https://codereview.chromium.org/319303003/diff/20001/chrome/browser/resources/ssl/interstitial_v2.html#newcode14 chrome/browser/resources/ssl/interstitial_v2.html:14: <body i18n-values=".style.fontFamily:fontfamily"> or maybe you could move .style.fontSize to ...
6 years, 6 months ago (2014-06-07 03:03:15 UTC) #4
Dan Beam
btw, where is the 2x asset?
6 years, 6 months ago (2014-06-07 03:03:31 UTC) #5
felt
On 2014/06/07 03:03:31, Dan Beam wrote: > btw, where is the 2x asset? I'll land ...
6 years, 6 months ago (2014-06-07 03:09:19 UTC) #6
felt
https://codereview.chromium.org/319303003/diff/20001/chrome/browser/resources/ssl/interstitial_v2.html File chrome/browser/resources/ssl/interstitial_v2.html (right): https://codereview.chromium.org/319303003/diff/20001/chrome/browser/resources/ssl/interstitial_v2.html#newcode14 chrome/browser/resources/ssl/interstitial_v2.html:14: <body i18n-values=".style.fontFamily:fontfamily"> On 2014/06/07 03:03:15, Dan Beam wrote: > ...
6 years, 6 months ago (2014-06-07 03:21:54 UTC) #7
Dan Beam
lgtm
6 years, 6 months ago (2014-06-09 19:04:49 UTC) #8
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-09 19:49:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/319303003/80001
6 years, 6 months ago (2014-06-09 19:52:10 UTC) #10
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 6 months ago (2014-06-10 04:39:27 UTC) #11
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-10 04:39:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/319303003/80001
6 years, 6 months ago (2014-06-10 04:40:14 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:13:23 UTC) #14
Message was sent while issue was closed. 
Change committed as 276048

Powered by Google App Engine
This is Rietveld 408576698