Polish the new SSL interstitial

chrome/browser/ssl/ssl_blocking_page.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
@@ skipping 402 matching lines @@
 
   base::StringPiece html(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           resource_id));
   return webui::GetI18nTemplateHtml(html, &strings);
 }
 
 std::string SSLBlockingPage::GetHTMLContentsV2() {
   base::DictionaryValue loadTimeData;
   base::string16 url(ASCIIToUTF16(request_url_.host()));
-  bool rtl = base::i18n::IsRTL();
-  loadTimeData.SetString("textDirection", rtl ? "rtl" : "ltr");
-  if (rtl)
+  if (base::i18n::IsRTL())
     base::i18n::WrapStringWithLTRFormatting(&url);
   webui::SetFontAndTextDirection(&loadTimeData);
 

[Dan Beam, 2014/06/07 03:03:15]

can't you just do:

  loadTimeData.SetDouble("fontSize",
      1.25 * loadTimeData.GetDouble("fontSize"));

to essentially increase the font size by 25%?

   // Shared values for both the overridable and non-overridable versions.
   loadTimeData.SetBoolean("overridable", overridable_ && !strict_enforcement_);
   loadTimeData.SetString(
       "tabTitle", l10n_util::GetStringUTF16(IDS_SSL_V2_TITLE));
   loadTimeData.SetString(
       "heading", l10n_util::GetStringUTF16(IDS_SSL_V2_HEADING));
   loadTimeData.SetString(
       "primaryParagraph",
       l10n_util::GetStringFUTF16(IDS_SSL_V2_PRIMARY_PARAGRAPH, url));
   loadTimeData.SetString(
@@ skipping 213 matching lines @@
     // sure we don't clear the captive portal flag, since the interstitial was
     // potentially caused by the captive portal.
     captive_portal_detected_ = captive_portal_detected_ ||
         (results->result == captive_portal::RESULT_BEHIND_CAPTIVE_PORTAL);
     // Also keep track of non-HTTP portals and error cases.
     captive_portal_no_response_ = captive_portal_no_response_ ||
         (results->result == captive_portal::RESULT_NO_RESPONSE);
   }
 #endif
 }