chrome/browser/resources/ssl/interstitial_v2.html - Issue 319303003: Polish the new SSL interstitial

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/ssl/interstitial_v2.html

Issue 319303003: Polish the new SSL interstitial (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textDirection">	2 <html i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <meta name="viewport"	5 <meta name="viewport"

6 content="initial-scale=1, minimum-scale=1, width=device-width">	6 content="initial-scale=1, minimum-scale=1, width=device-width">

7 <title i18n-content="tabTitle"></title>	7 <title i18n-content="tabTitle"></title>

8 <link rel="stylesheet" href="interstitial_v2.css">	8 <link rel="stylesheet" href="interstitial_v2.css">

9 <script src="../../../../ui/webui/resources/js/util.js"></script>	9 <script src="../../../../ui/webui/resources/js/util.js"></script>

10 <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>	10 <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>

11 <script src="ssl_errors_common.js"></script>	11 <script src="ssl_errors_common.js"></script>

12 <script src="interstitial_v2.js"></script>	12 <script src="interstitial_v2.js"></script>

13 </head>	13 </head>

14 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">	14 <body i18n-values=".style.fontFamily:fontfamily">
Dan Beam 2014/06/07 02:04:42 ^ why do this? doesn't that mean users' default f ^ why do this? doesn't that mean users' default font size (set in settings) wont be respected anymore? felt 2014/06/07 02:56:12 We want the warnings to be very easy to read. I tr Show quoted text On 2014/06/07 02:04:42, Dan Beam wrote: > ^ why do this? doesn't that mean users' default font size (set in settings) > wont be respected anymore? We want the warnings to be very easy to read. I tried it out with the default sizes originally but the designers said the default text size is too small.
15 <div class="interstitial-wrapper">	15 <div class="interstitial-wrapper">

16 <div class="icon"></div>	16 <div class="icon"></div>

17 <div id="main-message">	17 <div id="main-message">

18 <h1 i18n-content="heading"></h1>	18 <h1 i18n-content="heading"></h1>

19 <p i18n-values=".innerHTML:primaryParagraph"></p>	19 <p i18n-values=".innerHTML:primaryParagraph"></p>

20 </div>	20 </div>

21 <div class="nav-wrapper">	21 <div class="nav-wrapper">

22 <button i18n-content="primaryButtonText" id="primary-button"></button>	22 <button i18n-content="primaryButtonText" id="primary-button"></button>

23 <a href="#" id="details-button" i18n-content="openDetails"></a>	23 <a href="#" id="details-button" i18n-content="openDetails"></a>

24 </div>	24 </div>

25 <div id="details" class="hidden">	25 <div id="details" class="hidden">

26 <p i18n-values=".innerHTML:explanationParagraph"></p>	26 <p i18n-values=".innerHTML:explanationParagraph"></p>

27 <p i18n-values=".innerHTML:finalParagraph"></p>	27 <p i18n-values=".innerHTML:finalParagraph" class="add-top-margin"></p>
	Dan Beam 2014/06/07 02:04:42 remove class remove class felt 2014/06/07 02:56:12 Done. Show quoted text On 2014/06/07 02:04:42, Dan Beam wrote: > remove class Done.
28 </div>	28 </div>

29 </div>	29 </div>

30 </body>	30 </body>

31 </html>	31 </html>

OLD	NEW