[Safe browsing] Add a few new UMA metrics

[Safe browsing] Add a few new UMA metrics

These UMA metrics are added in
https://codereview.chromium.org/303233002
https://chrome-internal-review.googlesource.com/#/c/164968/

BUG=379256
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276098

[Feng Qian, 2014-06-05 22:19:59]

Ilya, can you take a look at the CL?

[Ilya Sherman, 2014-06-05 23:56:05]

https://codereview.chromium.org/318823003/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/318823003/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23177: +    Whether the user turns
on/off safe browsing in Settings page on Android.
Please document when this is logged -- is it at the time that the setting is
flipped?  If so, you're really counting how often users interact with the
setting, rather than the number of users who are in a given state.  If that's
the case, it would be good to make that really clear in the <summary>, so that
folks interacting with this histogram don't make an incorrect assumption about
its semantics.  (If the metric is really measuring interaction with the setting,
then it would have been helpful to name it something more like
"SafeBrowsing.EnabledSettingChanged".)

[Feng Qian, 2014-06-09 17:20:18]

https://codereview.chromium.org/318823003/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/318823003/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:23177: +    Whether the user turns
on/off safe browsing in Settings page on Android.
Done, thanks for the comment!

On 2014/06/05 23:56:05, Ilya Sherman wrote:
> Please document when this is logged -- is it at the time that the setting is
> flipped?  If so, you're really counting how often users interact with the
> setting, rather than the number of users who are in a given state.  If that's
> the case, it would be good to make that really clear in the <summary>, so that
> folks interacting with this histogram don't make an incorrect assumption about
> its semantics.  (If the metric is really measuring interaction with the
setting,
> then it would have been helpful to name it something more like
> "SafeBrowsing.EnabledSettingChanged".)

[Ilya Sherman, 2014-06-09 23:21:31]

LGTM, thanks.

[Feng Qian, 2014-06-09 23:31:11]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-06-09 23:35:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/318823003/20001

[commit-bot: I haz the power, 2014-06-10 18:38:37]

Change committed as 276098