tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index c2fd7d37eab4039981be042eb11627f6fe788b5f..135a4485decb80cffc3e7b21cb762cd57da58a3d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -23171,6 +23171,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="SafeBrowsing.Enabled" enum="BooleanEnabled">
+  <owner>feng@chromium.org</owner>
+  <summary>
+    Whether the user turns on/off safe browsing in Settings page on Android.

[Ilya Sherman, 2014/06/05 23:56:05]

Please document when this is logged -- is it at the time that the setting is
flipped?  If so, you're really counting how often users interact with the
setting, rather than the number of users who are in a given state.  If that's
the case, it would be good to make that really clear in the <summary>, so that
folks interacting with this histogram don't make an incorrect assumption about
its semantics.  (If the metric is really measuring interaction with the setting,
then it would have been helpful to name it something more like
"SafeBrowsing.EnabledSettingChanged".)

[Feng Qian, 2014/06/09 17:20:18]

Done, thanks for the comment!

On 2014/06/05 23:56:05, Ilya Sherman wrote:

+  </summary>
+</histogram>
+
 <histogram name="SB.BloomFilter" units="milliseconds">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <summary>
@@ -23972,6 +23979,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <summary>The size of all the chunk URLs in an update response.</summary>
 </histogram>
 
+<histogram name="SB2.UpdateSizeBackground" units="bytes">
+  <owner>feng@chromium.org</owner>
+  <summary>
+    The size of all the chunk URLs in an update response when Chrome is in the
+    foreground.
+  </summary>
+</histogram>
+
+<histogram name="SB2.UpdateSizeForeground" units="bytes">
+  <owner>feng@chromium.org</owner>
+  <summary>
+    The size of all the chunk URLs in an update response when Chrome is in the
+    background.
+  </summary>
+</histogram>
+
 <histogram name="SB2.UpdateUrls">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <summary>The number of chunk URLs in an update response.</summary>