Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 303233002: [Android] Add UMA SB download size in background and foreground. (Closed)

Created:
6 years, 6 months ago by Feng Qian
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Add UMA SB download size in background and foreground. On Android, we'd like to know how much data downloaded when app is in foreground and background. The changes adds an API for application to notify protocol manager about status changes. BUG=376029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273985

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase and address reviewer's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/safe_browsing/protocol_manager.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
klobag.chromium
lgtm
6 years, 6 months ago (2014-05-30 05:38:34 UTC) #1
Scott Hess - ex-Googler
lgtm otherwise https://chromiumcodereview.appspot.com/303233002/diff/1/chrome/browser/safe_browsing/protocol_manager.cc File chrome/browser/safe_browsing/protocol_manager.cc (right): https://chromiumcodereview.appspot.com/303233002/diff/1/chrome/browser/safe_browsing/protocol_manager.cc#newcode716 chrome/browser/safe_browsing/protocol_manager.cc:716: UMA_HISTOGRAM_COUNTS("SB2.UpdateSize", update_size_); This should probably just be ...
6 years, 6 months ago (2014-05-30 16:08:21 UTC) #2
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-05-30 17:44:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/303233002/20001
6 years, 6 months ago (2014-05-30 17:46:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 23:27:45 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:45:44 UTC) #6
Message was sent while issue was closed.
Change committed as 273985

Powered by Google App Engine
This is Rietveld 408576698