Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 318633002: Speculative Fix for crash in WebCore::Internals::IsSelectPopupVisible (Closed)

Created:
6 years, 6 months ago by Sunil Ratnu
Modified:
6 years, 6 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Speculative Fix for crash in WebCore::Internals::IsSelectPopupVisible The possible reason of crash seems to be renderer value being null. R=tkent@chromium.org BUG=356128 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sunil Ratnu
Please review this patch.
6 years, 6 months ago (2014-06-04 08:48:06 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-04 09:04:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/318633002/1
6 years, 6 months ago (2014-06-04 09:05:59 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 10:30:44 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 13:00:36 UTC) #5
Message was sent while issue was closed.
Change committed as 175478

Powered by Google App Engine
This is Rietveld 408576698