Source/core/testing/Internals.cpp - Issue 318633002: Speculative Fix for crash in WebCore::Internals::IsSelectPopupVisible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/Internals.cpp

Issue 318633002: Speculative Fix for crash in WebCore::Internals::IsSelectPopupVisible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/testing/Internals.cpp

diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp

index f312c9065ea572bb4fa5ec9c5ff465903a591a6a..e453595285acb6d9e98a70fb5814babb3abd58cd 100644

--- a/Source/core/testing/Internals.cpp

+++ b/Source/core/testing/Internals.cpp

@@ -2220,7 +2220,7 @@ bool Internals::isSelectPopupVisible(Node* node)

HTMLSelectElement& select = toHTMLSelectElement(*node);

RenderObject* renderer = select.renderer();

- if (!renderer->isMenuList())

+ if (!renderer || !renderer->isMenuList())

return false;

RenderMenuList* menuList = toRenderMenuList(renderer);

« no previous file with comments | « no previous file | no next file » | no next file with comments »