Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 318633002: Speculative Fix for crash in WebCore::Internals::IsSelectPopupVisible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 2202 matching lines...) Expand 10 before | Expand all | Expand 10 after
2213 2213
2214 bool Internals::isSelectPopupVisible(Node* node) 2214 bool Internals::isSelectPopupVisible(Node* node)
2215 { 2215 {
2216 ASSERT(node); 2216 ASSERT(node);
2217 if (!isHTMLSelectElement(*node)) 2217 if (!isHTMLSelectElement(*node))
2218 return false; 2218 return false;
2219 2219
2220 HTMLSelectElement& select = toHTMLSelectElement(*node); 2220 HTMLSelectElement& select = toHTMLSelectElement(*node);
2221 2221
2222 RenderObject* renderer = select.renderer(); 2222 RenderObject* renderer = select.renderer();
2223 if (!renderer->isMenuList()) 2223 if (!renderer || !renderer->isMenuList())
2224 return false; 2224 return false;
2225 2225
2226 RenderMenuList* menuList = toRenderMenuList(renderer); 2226 RenderMenuList* menuList = toRenderMenuList(renderer);
2227 return menuList->popupIsVisible(); 2227 return menuList->popupIsVisible();
2228 } 2228 }
2229 2229
2230 bool Internals::loseSharedGraphicsContext3D() 2230 bool Internals::loseSharedGraphicsContext3D()
2231 { 2231 {
2232 OwnPtr<blink::WebGraphicsContext3DProvider> sharedProvider = adoptPtr(blink: :Platform::current()->createSharedOffscreenGraphicsContext3DProvider()); 2232 OwnPtr<blink::WebGraphicsContext3DProvider> sharedProvider = adoptPtr(blink: :Platform::current()->createSharedOffscreenGraphicsContext3DProvider());
2233 if (!sharedProvider) 2233 if (!sharedProvider)
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
2369 } else if (type == "none") { 2369 } else if (type == "none") {
2370 webtype = blink::ConnectionTypeNone; 2370 webtype = blink::ConnectionTypeNone;
2371 } else { 2371 } else {
2372 exceptionState.throwDOMException(NotFoundError, ExceptionMessages::faile dToEnumerate("connection type", type)); 2372 exceptionState.throwDOMException(NotFoundError, ExceptionMessages::faile dToEnumerate("connection type", type));
2373 return; 2373 return;
2374 } 2374 }
2375 networkStateNotifier().setWebConnectionTypeForTest(webtype); 2375 networkStateNotifier().setWebConnectionTypeForTest(webtype);
2376 } 2376 }
2377 2377
2378 } // namespace WebCore 2378 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698