Prevent derived classes of GuestViewBase from overriding key methods

Prevent derived classes of GuestViewBase from overriding key methods

This change removes the obligation for the derived class to call the base class' implementation at the end. This makes it easier to write GuestViewBase derived classes.

BUG=364141
330264

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274801

[lazyboy, 2014-06-03 18:11:34]

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
File chrome/browser/guest_view/guest_view_base.h (right):

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/guest_view_base.h:83: // This method can be overriden
by subclasses. This method is called when
s/overriden/overridden, here and in other places.

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/guest_view_base.h:84: // the guest WebContents is
about to be destroyed. This gives the derived
// Called when guest WC is about to be destroyed should come as first line.

// Called when guest WC is about to be destroyed.
//
// This method can be ... This gives ...
virtual void WillBeDestroyed();

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/guest_view_base.h:86: virtual void WillBeDestroyed()
{}
nit: "WillDestroy" is more common in chromium codebase.

[Fady Samuel, 2014-06-04 00:43:00]

PTAL

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
File chrome/browser/guest_view/guest_view_base.h (right):

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/guest_view_base.h:83: // This method can be overriden
by subclasses. This method is called when
On 2014/06/03 18:11:34, lazyboy wrote:
> s/overriden/overridden, here and in other places.

Done.

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/guest_view_base.h:84: // the guest WebContents is
about to be destroyed. This gives the derived
On 2014/06/03 18:11:34, lazyboy wrote:
> // Called when guest WC is about to be destroyed should come as first line.
> 
> // Called when guest WC is about to be destroyed.
> //
> // This method can be ... This gives ...
> virtual void WillBeDestroyed();

Done.

https://codereview.chromium.org/318433002/diff/20001/chrome/browser/guest_vie...
chrome/browser/guest_view/guest_view_base.h:86: virtual void WillBeDestroyed()
{}
On 2014/06/03 18:11:34, lazyboy wrote:
> nit: "WillDestroy" is more common in chromium codebase.

Done.

[lazyboy, 2014-06-04 03:15:06]

lgtm

[Fady Samuel, 2014-06-04 05:03:56]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-06-04 05:05:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/318433002/40001

[commit-bot: I haz the power, 2014-06-04 13:08:07]

Change committed as 274801