Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2899)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 318433002: Prevent derived classes of GuestViewBase from overriding key methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/web_view/web_view_guest.h
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h
index 87e26fe3b5749c3cd17646ad6b23a19ef465ecab..0491aa6b265775b2b5290d475606d293844215c9 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.h
+++ b/chrome/browser/guest_view/web_view/web_view_guest.h
@@ -71,7 +71,9 @@ class WebViewGuest : public GuestView<WebViewGuest>,
const base::DictionaryValue& args) OVERRIDE;
virtual void DidStopLoading() OVERRIDE;
virtual void EmbedderDestroyed() OVERRIDE;
+ virtual void GuestDestroyed() OVERRIDE;
virtual bool IsDragAndDropEnabled() const OVERRIDE;
+ virtual void WillDestroy() OVERRIDE;
// WebContentsDelegate implementation.
virtual bool AddMessageToConsole(content::WebContents* source,
@@ -136,7 +138,6 @@ class WebViewGuest : public GuestView<WebViewGuest>,
bool last_unlocked_by_target,
const base::Callback<void(bool)>& callback) OVERRIDE;
virtual void NavigateGuest(const std::string& src) OVERRIDE;
- virtual void Destroy() OVERRIDE;
// NotificationObserver implementation.
virtual void Observe(int type,
@@ -299,7 +300,6 @@ class WebViewGuest : public GuestView<WebViewGuest>,
const IPC::Message& message,
content::RenderFrameHost* render_frame_host) OVERRIDE;
virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;
- virtual void WebContentsDestroyed() OVERRIDE;
virtual void UserAgentOverrideSet(const std::string& user_agent) OVERRIDE;
virtual void RenderViewReady() OVERRIDE;
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698