chrome/browser/guest_view/guest_view_base.cc - Issue 318433002: Prevent derived classes of GuestViewBase from overriding key methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 318433002: Prevent derived classes of GuestViewBase from overriding key methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/guest_view/guest_view_base.cc

diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc

index 5acf36a2777507e8b67c769c1f87a313186073cc..41e2e2f696a666d757041784ec3734f7238bd4b2 100644

--- a/chrome/browser/guest_view/guest_view_base.cc

+++ b/chrome/browser/guest_view/guest_view_base.cc

@@ -211,6 +211,7 @@ void GuestViewBase::Attach(content::WebContents* embedder_web_contents,

}

void GuestViewBase::Destroy() {

+ WillDestroy();

if (!destruction_callback_.is_null())

destruction_callback_.Run();

delete guest_web_contents();

@@ -242,6 +243,7 @@ void GuestViewBase::DidStopLoading(content::RenderViewHost* render_view_host) {

}

void GuestViewBase::WebContentsDestroyed() {

+ GuestDestroyed();

delete this;

}

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »