Issue 318383003: Improve error messages and reporting in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318383003: Improve error messages and reporting in GN (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve error messages and reporting in GN Update help for cflags to reference new escaping behavior. We now escape spaces. The main reason it didn't do this before was pkg-config integration, but we now have specialized scripts to wrap pkgconfig. Improve error message when a label doesn't match. This is a common one to run into. Add the origin when a load fails. Previously if you mistyped a label in a dependency you would get a message about the file not loading but no location, which made it very hard to track down. This plumbs through the original location to the actual load. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276064

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -36 lines)			Patch
M	tools/gn/builder.cc	View	1	2 chunks	+12 lines, -8 lines	0 comments	Download
M	tools/gn/builder_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/input_file_manager.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/gn/loader.h	View		5 chunks	+5 lines, -1 line	0 comments	Download
M	tools/gn/loader.cc	View		8 chunks	+29 lines, -11 lines	0 comments	Download
M	tools/gn/loader_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/gn/setup.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/variables.cc	View		3 chunks	+1 line, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 6 months ago (2014-06-10 17:48:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r276064 (presubmit successful).

Expand Messages | Collapse Messages