Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gn/loader_unittest.cc

Issue 318383003: Improve error messages and reporting in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/setup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/loader_unittest.cc
diff --git a/tools/gn/loader_unittest.cc b/tools/gn/loader_unittest.cc
index 6397684c2cc566055ea4630ccb3db46deb6e5292..e5a3d86009bedead648ac39cc1a42e993c835939 100644
--- a/tools/gn/loader_unittest.cc
+++ b/tools/gn/loader_unittest.cc
@@ -146,7 +146,7 @@ TEST_F(LoaderTest, Foo) {
// Request the root build file be loaded. This should kick off the default
// build config loading.
SourceFile root_build("//BUILD.gn");
- loader->Load(root_build, Label());
+ loader->Load(root_build, LocationRange(), Label());
EXPECT_TRUE(mock_ifm_.HasOnePending(build_config));
// Completing the build config load should kick off the root build file load.
@@ -161,7 +161,7 @@ TEST_F(LoaderTest, Foo) {
// Schedule some other file to load in another toolchain.
Label second_tc(SourceDir("//tc2/"), "tc2");
SourceFile second_file("//foo/BUILD.gn");
- loader->Load(second_file, second_tc);
+ loader->Load(second_file, LocationRange(), second_tc);
EXPECT_TRUE(mock_ifm_.HasOnePending(SourceFile("//tc2/BUILD.gn")));
// Running the toolchain file should schedule the build config file to load
@@ -179,7 +179,7 @@ TEST_F(LoaderTest, Foo) {
// Scheduling a second file to load in that toolchain should not make it
// pending yet (it's waiting for the build config).
SourceFile third_file("//bar/BUILD.gn");
- loader->Load(third_file, second_tc);
+ loader->Load(third_file, LocationRange(), second_tc);
EXPECT_TRUE(mock_ifm_.HasOnePending(build_config));
// Running the build config file should make our third file pending.
« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/setup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698