Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/gn/loader.h

Issue 318383003: Improve error messages and reporting in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/input_file_manager.cc ('k') | tools/gn/loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/loader.h
diff --git a/tools/gn/loader.h b/tools/gn/loader.h
index 4d9e4cdd505e52d55dc0ab187c37bc8ff283f5cf..29204ae65ef884743ae332d3ed9011a8e58fc227 100644
--- a/tools/gn/loader.h
+++ b/tools/gn/loader.h
@@ -18,6 +18,7 @@ class MessageLoop;
}
class BuildSettings;
+class LocationRange;
class Settings;
class SourceFile;
class Toolchain;
@@ -37,6 +38,7 @@ class Loader : public base::RefCountedThreadSafe<Loader> {
// empty toolchain name, which will trigger the load of the default build
// config.
virtual void Load(const SourceFile& file,
+ const LocationRange& origin,
const Label& toolchain_name) = 0;
// Notification that the given toolchain has loaded. This will unblock files
@@ -52,7 +54,7 @@ class Loader : public base::RefCountedThreadSafe<Loader> {
// Helper function that extracts the file and toolchain name from the given
// label, and calls Load().
- void Load(const Label& label);
+ void Load(const Label& label, const LocationRange& origin);
// Returns the build file that the given label references.
static SourceFile BuildFileForLabel(const Label& label);
@@ -81,6 +83,7 @@ class LoaderImpl : public Loader {
// Loader implementation.
virtual void Load(const SourceFile& file,
+ const LocationRange& origin,
const Label& toolchain_name) OVERRIDE;
virtual void ToolchainLoaded(const Toolchain* toolchain) OVERRIDE;
virtual Label GetDefaultToolchain() const OVERRIDE;
@@ -116,6 +119,7 @@ class LoaderImpl : public Loader {
// Schedules the input file manager to load the given file.
void ScheduleLoadFile(const Settings* settings,
+ const LocationRange& origin,
const SourceFile& file);
void ScheduleLoadBuildConfig(
Settings* settings,
« no previous file with comments | « tools/gn/input_file_manager.cc ('k') | tools/gn/loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698