Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318383002: Revert 275781 "Revert 273044 "Change kEnableAudioTrackProcessing..." (Closed)

Created:
6 years, 6 months ago by no longer working on chromium
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 275781 "Revert 273044 "Change kEnableAudioTrackProcessing..." > Revert 273044 "Change kEnableAudioTrackProcessing to a disable f..." > > > Change kEnableAudioTrackProcessing to a disable flag and remove finch code for AudioTrackProcessing. > > > > The plan is to enable audio processing in getUserMedia as default for M37, and keep a kDisableAudioTrackProcessing flag to be able to fall back to the old path. > > > > BUG=365672 > > TEST=bots > > > > Review URL: https://codereview.chromium.org/293023003 > > TBR=xians@chromium.org > > Review URL: https://codereview.chromium.org/318373002 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -50 lines) Patch
M trunk/src/chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/media/webrtc_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/media/webrtc_getusermedia_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc View 5 chunks +3 lines, -15 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_capturer_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_local_audio_track.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
no longer working on chromium
6 years, 6 months ago (2014-06-09 08:27:08 UTC) #1
no longer working on chromium
6 years, 6 months ago (2014-06-09 08:27:27 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r275782 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698