Make CUS interface more resilient by returning a copy of the data

Make CUS interface more resilient by returning a copy of the data instead of raw pointer.

The idea here is to elminate the ambiguity about who owns what and protect
about misuse by callers.

BUG=381710
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276561

[waffles, 2014-06-07 00:26:09]

lgtm; please try it and stuff of course

[Sorin Jianu, 2014-06-07 05:28:53]

Carlos?

[cpu_(ooo_6.6-7.5), 2014-06-09 23:12:57]

https://codereview.chromium.org/318143003/diff/20001/chrome/browser/component...
File chrome/browser/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/318143003/diff/20001/chrome/browser/component...
chrome/browser/component_updater/component_updater_service.h:212: virtual
base::WeakPtr<CrxUpdateItem> GetComponentDetails(
This sparked an interesting discussion among few folks. The conclusion is that
WeakPtr is not the appropriate mechanism for this and if you really want to
avoid naked ptrs a const reference would be the best way to go about here.

I personally can live with as is from the perspective of being a private
function or make it a cons ref.

[waffles, 2014-06-10 17:14:07]

lgtm

[Sorin Jianu, 2014-06-10 17:18:24]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-06-10 17:20:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/318143003/60001

[cpu_(ooo_6.6-7.5), 2014-06-10 18:20:24]

lgtm

[commit-bot: I haz the power, 2014-06-11 01:15:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 01:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 01:20:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Sorin Jianu, 2014-06-11 02:06:39]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-06-11 02:08:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/318143003/60001

[commit-bot: I haz the power, 2014-06-11 07:18:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 07:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 07:24:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Sorin Jianu, 2014-06-11 16:10:22]

James, please, I need an owner review for
chrome\browser\ui\webui\components_ui.cc

Thank you!

[James Hawkins, 2014-06-11 17:50:39]

https://codereview.chromium.org/318143003/diff/60001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/components_ui.cc (right):

https://codereview.chromium.org/318143003/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/components_ui.cc:172: const bool res =
cus->GetComponentDetails(component_ids[j], &item);
What does 'res' mean?  Can we get a better variable name?  We could simplify it
further by:

if (cus->GetComponentDetails(...)) {
...
}

[Sorin Jianu, 2014-06-11 21:39:41]

Thank you James. Fixed.

https://codereview.chromium.org/318143003/diff/60001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/components_ui.cc (right):

https://codereview.chromium.org/318143003/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/components_ui.cc:172: const bool res =
cus->GetComponentDetails(component_ids[j], &item);
On 2014/06/11 17:50:39, James Hawkins wrote:
> What does 'res' mean?  Can we get a better variable name?  We could simplify
it
> further by:
> 
> if (cus->GetComponentDetails(...)) {
> ...
> }

Done.

[James Hawkins, 2014-06-11 21:52:19]

lgtm

[Sorin Jianu, 2014-06-11 22:05:07]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:07:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/318143003/80001

[commit-bot: I haz the power, 2014-06-11 22:59:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15705)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18838)

[commit-bot: I haz the power, 2014-06-11 23:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:01:28]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15750)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18882)

[Sorin Jianu, 2014-06-11 23:08:47]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:09:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/318143003/80001

[commit-bot: I haz the power, 2014-06-11 23:15:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15761)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18893)

[commit-bot: I haz the power, 2014-06-11 23:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:17:21]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15765)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18897)

[Sorin Jianu, 2014-06-11 23:27:14]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:28:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/318143003/80001

[commit-bot: I haz the power, 2014-06-12 00:25:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15771)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18903)

[commit-bot: I haz the power, 2014-06-12 00:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:27:19]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15817)

[Sorin Jianu, 2014-06-12 00:57:40]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:58:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/318143003/80001

[commit-bot: I haz the power, 2014-06-12 07:26:05]

Change committed as 276561