Make CUS interface more resilient by returning a copy of the data

chrome/browser/ui/webui/components_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/components_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 150 matching lines @@
 // static
 base::ListValue* ComponentsUI::LoadComponents() {
   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
   std::vector<std::string> component_ids;
   component_ids = cus->GetComponentIDs();
 
   // Construct DictionaryValues to return to UI.
   base::ListValue* component_list = new base::ListValue();
   for (size_t j = 0; j < component_ids.size(); ++j) {
-    const component_updater::CrxUpdateItem* item =
-        cus->GetComponentDetails(component_ids[j]);
-    if (item) {
+    component_updater::CrxUpdateItem item;
+    const bool res = cus->GetComponentDetails(component_ids[j], &item);

[James Hawkins, 2014/06/11 17:50:39]

What does 'res' mean?  Can we get a better variable name?  We could simplify it
further by:

if (cus->GetComponentDetails(...)) {
...
}

[Sorin Jianu, 2014/06/11 21:39:41]

Done.

+    if (res) {
       base::DictionaryValue* component_entry = new base::DictionaryValue();
       component_entry->SetString("id", component_ids[j]);
-      component_entry->SetString("name", item->component.name);
-      component_entry->SetString("version",
-                                 item->component.version.GetString());
-
-      component_entry->SetString("status",
-                                 ServiceStatusToString(item->status));
-
+      component_entry->SetString("name", item.component.name);
+      component_entry->SetString("version", item.component.version.GetString());
+      component_entry->SetString("status", ServiceStatusToString(item.status));
       component_list->Append(component_entry);
     }
   }
 
   return component_list;
 }
 
 // static
 base::RefCountedMemory* ComponentsUI::GetFaviconResourceBytes(
       ui::ScaleFactor scale_factor) {
@@ skipping 50 matching lines @@
   return l10n_util::GetStringUTF16(IDS_COMPONENTS_UNKNOWN);
 }
 
 void ComponentsUI::OnEvent(Events event, const std::string& id) {
   base::DictionaryValue parameters;
   parameters.SetString("event", ComponentEventToString(event));
   if (!id.empty())
     parameters.SetString("id", id);
   web_ui()->CallJavascriptFunction("onComponentEvent", parameters);
 }