Make CUS interface more resilient by returning a copy of the data

chrome/browser/component_updater/component_updater_service.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 189 matching lines @@
   // Returns a list of registered components.
   virtual std::vector<std::string> GetComponentIDs() const = 0;
 
   // Returns an interface for on-demand updates. On-demand updates are
   // proactively triggered outside the normal component update service schedule.
   virtual OnDemandUpdater& GetOnDemandUpdater() = 0;
 
   virtual ~ComponentUpdateService() {}
 
  private:
-  // Returns details about registered component. The object returned is owned
-  // by this class. TODO(sorin): replace with a WeakPtr.
-  virtual CrxUpdateItem* GetComponentDetails(
-      const std::string& component_id) const = 0;
+  // Returns details about registered component in the |item| parameter. The
+  // function returns true in case of success and false in case of errors.
+  virtual bool GetComponentDetails(const std::string& component_id,
+                                   CrxUpdateItem* item) const = 0;
 
   friend class ::ComponentsUI;
   FRIEND_TEST_ALL_PREFIXES(ComponentUpdaterTest, ResourceThrottleLiveNoUpdate);
 };
 
 typedef ComponentUpdateService::Observer ServiceObserver;
 
 class OnDemandUpdater {
  public:
   virtual ~OnDemandUpdater() {}
@@ skipping 23 matching lines @@
       const std::string& component_id) = 0;
 };
 
 // Creates the component updater. You must pass a valid |config| allocated on
 // the heap which the component updater will own.
 ComponentUpdateService* ComponentUpdateServiceFactory(
     ComponentUpdateService::Configurator* config);
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_