tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py - Issue 317913003: Remove 'navigate' attribute from wait_until

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

Issue 317913003: Remove 'navigate' attribute from wait_until (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py ('k') | tools/telemetry/telemetry/core/tab.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

index c65f70b3cd291b4686cc72fcf3481d1ba15da99a..07f7d6bbf050d799624820fa160a36ddd69c24eb 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

@@ -66,9 +66,8 @@ class WebDriverTabBackend(object):

# Webdriver has no API for DOM status.

raise NotImplementedError()

- def PerformActionAndWaitForNavigate(self, action_function, _):

- # TODO(chrisgao): Double check of navigation.

- action_function()

+ def WaitForNavigate(self):

+ raise NotImplementedError()

def Navigate(self, url, script_to_evaluate_on_commit=None, timeout=None):

if script_to_evaluate_on_commit:

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py ('k') | tools/telemetry/telemetry/core/tab.py » ('j') | no next file with comments »