tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py - Issue 317913003: Remove 'navigate' attribute from wait_until

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py

Issue 317913003: Remove 'navigate' attribute from wait_until (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_page.py ('k') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py

index 0343920432f43872c39b77a5efd4cf50136ab279..7408a092c6399be1d2b275ab490cf310991ee108 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py

@@ -21,14 +21,9 @@ class InspectorPageTest(tab_test_case.TabTestCase):

self._tab.EvaluateJavaScript('document.location.pathname;'),

'/page_with_link.html')

- custom_action_called = [False]

- def CustomAction():

- custom_action_called[0] = True

- self._tab.ExecuteJavaScript('document.getElementById("clickme").click();')

+ self._tab.ExecuteJavaScript('document.getElementById("clickme").click();')

+ self._tab.WaitForNavigate()

- self._tab.PerformActionAndWaitForNavigate(CustomAction)

- self.assertTrue(custom_action_called[0])

self.assertEquals(

self._tab.EvaluateJavaScript('document.location.pathname;'),

'/blank.html')