Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: tools/telemetry/telemetry/core/tab.py

Issue 317913003: Remove 'navigate' attribute from wait_until (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/tab.py
diff --git a/tools/telemetry/telemetry/core/tab.py b/tools/telemetry/telemetry/core/tab.py
index 70eb31ebad2a95e84514402ffc513ab0b6b45e31..b6d6371a79a83277626f27baa3b2b03928888f1c 100644
--- a/tools/telemetry/telemetry/core/tab.py
+++ b/tools/telemetry/telemetry/core/tab.py
@@ -237,16 +237,14 @@ class Tab(web_contents.WebContents):
for timestamp, bmp in frame_generator:
yield timestamp - start_time, bmp.Crop(*content_box)
- def PerformActionAndWaitForNavigate(
- self, action_function, timeout=DEFAULT_TAB_TIMEOUT):
- """Executes action_function, and waits for the navigation to complete.
+ def WaitForNavigate(self, timeout=DEFAULT_TAB_TIMEOUT):
+ """Waits for the navigation to complete.
- action_function must be a Python function that results in a navigation.
+ The current page is expect to be in a navigation.
This function returns when the navigation is complete or when
the timeout has been exceeded.
"""
- self._inspector_backend.PerformActionAndWaitForNavigate(
- action_function, timeout)
+ self._inspector_backend.WaitForNavigate(timeout)
def Navigate(self, url, script_to_evaluate_on_commit=None,
timeout=DEFAULT_TAB_TIMEOUT):

Powered by Google App Engine
This is Rietveld 408576698