Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 317653003: [Arm] Various cleanups to the Arm assembler backend. (Closed)

Created:
6 years, 6 months ago by rmcilroy
Modified:
6 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

[Arm] Various cleanups to the Arm assembler backend. A couple of cleanups to the Arm backend to enable support of extended OOL constant pools in a following CL. - Remove instruction pattern extern const's and replace their use with IsXXX() functions. - Do calculation of the target address of a load from constant pool in one place. - A couple of other small cleanups. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21932

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -177 lines) Patch
M src/arm/assembler-arm.h View 4 chunks +4 lines, -31 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +29 lines, -6 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 5 chunks +57 lines, -63 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +0 lines, -58 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
PTAL, thanks.
6 years, 6 months ago (2014-06-04 12:33:24 UTC) #1
ulan
lgtm
6 years, 6 months ago (2014-06-05 07:08:57 UTC) #2
rmcilroy
6 years, 6 months ago (2014-06-23 11:27:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21932 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698