Change FrameTree to return Frames instead of LocalFrames.

Source/web/SpellCheckerClientImpl.cpp

Index: Source/web/SpellCheckerClientImpl.cpp
diff --git a/Source/web/SpellCheckerClientImpl.cpp b/Source/web/SpellCheckerClientImpl.cpp
index 378616131f2d4271c584d5982baa592b98fa8047..ced145104b221cc0a792db48d86b393d9fbb9e47 100644
--- a/Source/web/SpellCheckerClientImpl.cpp
+++ b/Source/web/SpellCheckerClientImpl.cpp
@@ -96,8 +96,12 @@ void SpellCheckerClientImpl::toggleContinuousSpellChecking()
     if (isContinuousSpellCheckingEnabled()) {
         m_spellCheckThisFieldStatus = SpellCheckForcedOff;
         if (Page* page = m_webView->page()) {
-            for (LocalFrame* frame = page->mainFrame(); frame && frame->document(); frame = frame->tree().traverseNext()) {
-                frame->document()->markers().removeMarkers(DocumentMarker::MisspellingMarkers());
+            for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+                if (!frame->isLocalFrame())
+                    continue;
+                if (!toLocalFrame(frame)->document())
+                    break;

[dcheng, 2014/06/04 18:06:37]

groby, is it intentional that we break out of the loop as soon as we encounter a
non-null document?

[dcheng, 2014/06/04 18:12:29]

I mean *null* document, sorry for the confusion.

[groby-ooo-7-16, 2014/06/04 18:28:14]

I'm not 100% certain - This was written by pstanek, so let me loop him in. In
general, in what case would we have contiguous text with a non-document frame in
between?

[dcheng, 2014/06/04 20:08:30]

In general, I don't think this is a normal condition to encounter. I guess you
might see this if this function got invoked in the middle of a frame getting
inserted into DOM, or during frame detach... but that doesn't seem like
something that should really be happening here. I think it's probably OK to just
remove the check...

+                toLocalFrame(frame)->document()->markers().removeMarkers(DocumentMarker::MisspellingMarkers());
             }
         }
     } else {