Change FrameTree to return Frames instead of LocalFrames.

Source/web/SpellCheckerClientImpl.cpp

 /*
  * Copyright (C) 2006, 2007 Apple, Inc.  All rights reserved.
  * Copyright (C) 2012 Google, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 78 matching lines @@
     if (m_spellCheckThisFieldStatus == SpellCheckForcedOn)
         return true;
     return shouldSpellcheckByDefault();
 }
 
 void SpellCheckerClientImpl::toggleContinuousSpellChecking()
 {
     if (isContinuousSpellCheckingEnabled()) {
         m_spellCheckThisFieldStatus = SpellCheckForcedOff;
         if (Page* page = m_webView->page()) {
-            for (LocalFrame* frame = page->mainFrame(); frame && frame->document(); frame = frame->tree().traverseNext()) {
-                frame->document()->markers().removeMarkers(DocumentMarker::MisspellingMarkers());
+            for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+                if (!frame->isLocalFrame())
+                    continue;
+                if (!toLocalFrame(frame)->document())
+                    break;

[dcheng, 2014/06/04 18:06:37]

groby, is it intentional that we break out of the loop as soon as we encounter a
non-null document?

[dcheng, 2014/06/04 18:12:29]

I mean *null* document, sorry for the confusion.

[groby-ooo-7-16, 2014/06/04 18:28:14]

I'm not 100% certain - This was written by pstanek, so let me loop him in. In
general, in what case would we have contiguous text with a non-document frame in
between?

[dcheng, 2014/06/04 20:08:30]

In general, I don't think this is a normal condition to encounter. I guess you
might see this if this function got invoked in the middle of a frame getting
inserted into DOM, or during frame detach... but that doesn't seem like
something that should really be happening here. I think it's probably OK to just
remove the check...

+                toLocalFrame(frame)->document()->markers().removeMarkers(DocumentMarker::MisspellingMarkers());
             }
         }
     } else {
         m_spellCheckThisFieldStatus = SpellCheckForcedOn;
         if (m_webView->focusedWebCoreFrame()->isLocalFrame()) {
             if (LocalFrame* frame = toLocalFrame(m_webView->focusedWebCoreFrame())) {
                 VisibleSelection frameSelection = frame->selection().selection();
                 // If a selection is in an editable element spell check its content.
                 if (Element* rootEditableElement = frameSelection.rootEditableElement()) {
                     frame->spellChecker().didBeginEditing(rootEditableElement);
@@ skipping 113 matching lines @@
 }
 
 bool SpellCheckerClientImpl::spellingUIIsShowing()
 {
     if (m_webView->spellCheckClient())
         return m_webView->spellCheckClient()->isShowingSpellingUI();
     return false;
 }
 
 } // namesace WebKit