Source/modules/geolocation/testing/InternalsGeolocation.cpp - Issue 317493002: Change FrameTree to return Frames instead of LocalFrames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/testing/InternalsGeolocation.cpp

Issue 317493002: Change FrameTree to return Frames instead of LocalFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed conflicts Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/geolocation/testing/InternalsGeolocation.cpp

diff --git a/Source/modules/geolocation/testing/InternalsGeolocation.cpp b/Source/modules/geolocation/testing/InternalsGeolocation.cpp

index 4de6488e9f88d72f6ee60b3fb7ce715f4ccd8be6..5386d3713de8ee44ccd5a661c9ab49fc4df5a04f 100644

--- a/Source/modules/geolocation/testing/InternalsGeolocation.cpp

+++ b/Source/modules/geolocation/testing/InternalsGeolocation.cpp

@@ -47,7 +47,7 @@ void InternalsGeolocation::setGeolocationClientMock(Internals&, Document* docume

ASSERT(document && document->frame());

GeolocationClientMock* client = new GeolocationClientMock();

- for (LocalFrame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().nextSibling())

+ for (Frame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().nextSibling())

dcheng 2014/06/04 18:06:37 I think you can just delete the for statement alto

kenrb 2014/06/04 20:34:47 This landed less than a day ago. I put a question

GeolocationController::from(document->frame())->setClientForTest(client);

}

« Source/core/page/FrameTree.cpp ('K') | « Source/core/testing/Internals.cpp ('k') | Source/web/SpellCheckerClientImpl.cpp » ('j') | Source/web/SpellCheckerClientImpl.cpp » ('J')