Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
317213004:
assert that we're not putting the same object twice into a dom wrapper map (Closed)
|
Created:
6 years, 6 months ago by jochen (gone - plz use gerrit) Modified:
6 years, 6 months ago CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
Descriptionassert that we're not putting the same object twice into a dom wrapper map
BUG=368095
R=vogelheim@chromium.org,dcarney@chromium.org,adamk@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175688
Patch Set 1 #
Messages
Total messages: 24 (0 generated)
lgtm
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/317213004/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
Do you have any confidence that we won't hit the ASSERT? When we inserted the ASSERT before, we hit the ASSERT. Now that we fixed a bunch of cross-world leakages, but I'm not quite sure if the fix is perfect. Now I'm trying to insert a verification about cross-world leakage into ScriptValue (https://codereview.chromium.org/314953005). The verification is failing and I'm investigating.
On 2014/06/06 12:30:46, haraken wrote: > Do you have any confidence that we won't hit the ASSERT? I'm pretty sure that we'll hit it, I want to get a few crash reports to get an idea about where it's coming from. Note that we currently just crash later when we try to remove the object twice from the map...
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/317213004/1
On 2014/06/06 12:33:17, jochen traveling until Jun 23 wrote: > On 2014/06/06 12:30:46, haraken wrote: > > Do you have any confidence that we won't hit the ASSERT? > > > I'm pretty sure that we'll hit it, I want to get a few crash reports to get an > idea about where it's coming from. > > Note that we currently just crash later when we try to remove the object twice > from the map... Makes sense. LGTM.
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7143)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7148)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/317213004/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7175)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7177)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/317213004/1
Message was sent while issue was closed.
Change committed as 175688
Message was sent while issue was closed.
On 2014/06/06 18:36:57, I haz the power (commit-bot) wrote: > Change committed as 175688 I'm interested in crash reports caused by the RELEASE_ASSERT introduced in this CL, so please cc me if you get any reports :) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
