Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: Source/bindings/v8/DOMWrapperMap.h

Issue 317213004: assert that we're not putting the same object twice into a dom wrapper map (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 } 63 }
64 64
65 bool containsKey(KeyType* key) 65 bool containsKey(KeyType* key)
66 { 66 {
67 return m_map.Contains(key); 67 return m_map.Contains(key);
68 } 68 }
69 69
70 void set(KeyType* key, v8::Handle<v8::Object> wrapper, const WrapperConfigur ation& configuration) 70 void set(KeyType* key, v8::Handle<v8::Object> wrapper, const WrapperConfigur ation& configuration)
71 { 71 {
72 ASSERT(static_cast<KeyType*>(toNative(wrapper)) == key); 72 ASSERT(static_cast<KeyType*>(toNative(wrapper)) == key);
73 ASSERT(!containsKey(key)); 73 RELEASE_ASSERT(!containsKey(key)); // See crbug.com/368095
74 v8::UniquePersistent<v8::Object> unique(m_isolate, wrapper); 74 v8::UniquePersistent<v8::Object> unique(m_isolate, wrapper);
75 configuration.configureWrapper(&unique); 75 configuration.configureWrapper(&unique);
76 m_map.Set(key, unique.Pass()); 76 m_map.Set(key, unique.Pass());
77 } 77 }
78 78
79 void clear() 79 void clear()
80 { 80 {
81 m_map.Clear(); 81 m_map.Clear();
82 } 82 }
83 83
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 v8::UniquePersistent<v8::Object> value, 160 v8::UniquePersistent<v8::Object> value,
161 void* key) 161 void* key)
162 { 162 {
163 RELEASE_ASSERT(!value.IsEmpty()); // See crbug.com/368095. 163 RELEASE_ASSERT(!value.IsEmpty()); // See crbug.com/368095.
164 releaseObject(v8::Local<v8::Object>::New(isolate, value)); 164 releaseObject(v8::Local<v8::Object>::New(isolate, value));
165 } 165 }
166 166
167 } // namespace WebCore 167 } // namespace WebCore
168 168
169 #endif // DOMWrapperMap_h 169 #endif // DOMWrapperMap_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698